This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH committed] Fix tautological comparison in non-executed part of tst-setuid2 (BZ #17058)
- From: Florian Weimer <fweimer at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 16 Jun 2014 18:02:10 +0200
- Subject: [PATCH committed] Fix tautological comparison in non-executed part of tst-setuid2 (BZ #17058)
- Authentication-results: sourceware.org; auth=none
This part never runs with the current implementation because the
setresuid call currently aborts (as intended).
--
Florian Weimer / Red Hat Product Security Team
2014-06-16 Florian Weimer <fweimer@redhat.com>
[BZ #17058]
* nptl/tst-setuid2.c (do_test): Fix tautological comparison in
non-executed part of the test.
diff --git a/NEWS b/NEWS
index 38cc5b5..52cd9b6 100644
--- a/NEWS
+++ b/NEWS
@@ -19,7 +19,7 @@ Version 2.20
16791, 16796, 16799, 16800, 16815, 16823, 16824, 16831, 16838, 16849,
16854, 16876, 16877, 16878, 16882, 16885, 16888, 16890, 16912, 16915,
16916, 16917, 16922, 16927, 16928, 16932, 16943, 16958, 16965, 16966,
- 16967, 16977, 16978, 16984, 16990, 16996, 17009, 17042, 17048.
+ 16967, 16977, 16978, 16984, 16990, 16996, 17009, 17042, 17048, 17058.
* The minimum Linux kernel version that this version of the GNU C Library
can be used with is 2.6.32.
diff --git a/nptl/tst-setuid2.c b/nptl/tst-setuid2.c
index 951aecc..260aa38 100644
--- a/nptl/tst-setuid2.c
+++ b/nptl/tst-setuid2.c
@@ -135,7 +135,7 @@ do_test (void)
/* If we get here, check that the kernel did the right thing. */
run_on_thread (get_thread_ids);
- if (ruid != 1001 || euid != 1002 || euid != 1003)
+ if (ruid != 1001 || euid != 1002 || suid != 1003)
FAIL ("unexpected UIDs after setuid: %ld, %ld, %ld",
(long) ruid, (long) euid, (long) suid);
return 0;