This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] Remove x86 assembler rwlock code
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andi Kleen <andi at firstfloor dot org>, libc-alpha at sourceware dot org
- Cc: Andi Kleen <ak at odo dot jf dot intel dot com>
- Date: Mon, 09 Jun 2014 15:15:39 -0400
- Subject: Re: [PATCH 2/3] Remove x86 assembler rwlock code
- Authentication-results: sourceware.org; auth=none
- References: <1399412209-28245-1-git-send-email-andi at firstfloor dot org> <1399412209-28245-3-git-send-email-andi at firstfloor dot org>
On 05/06/2014 05:36 PM, Andi Kleen wrote:
> From: Andi Kleen <ak@odo.jf.intel.com>
>
> With the recent tuning the C version of rwlocks is basically the same
> performance as the x86 assembler version for uncontended locks (with a
> a few cycles near the run-to-run variability). For others it should not
> matter anyways.
>
> So remove the assembler code and use the C version like other
> architectures.
Is there an objective microbenchmark we can add to the benchmark suite
that shows the assembly and C are roughly equivalent?
Cheers,
Carlos.