This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] fix nl_langinfo with static linking
- From: Aurelien Jarno <aurelien at aurel32 dot net>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 6 May 2014 23:10:32 +0200
- Subject: Re: [PATCH] fix nl_langinfo with static linking
- Authentication-results: sourceware.org; auth=none
- References: <1399385072-5600-1-git-send-email-aurelien at aurel32 dot net> <20140506210415 dot 80DA42C39A7 at topped-with-meat dot com>
On Tue, May 06, 2014 at 02:04:15PM -0700, Roland McGrath wrote:
> > + ($(objpfx)tst-langinfo.out): Redirect output.
>
> Mention use of $(evaluate-test) too.
$(evaluate-test) is not something new for tst-langinfo.out, it appears
there because the way the diff is done by git.
> > + default: /* Should be impossible. */
> > + return (char *) "";
>
> Make this an assert or abort rather than having the library function return
> the user error indication for a case that is an implementation bug.
>
> Otherwise looks fine to me (with BZ# added).
Ok, thanks for the review.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net