This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove PRI_MACROS_BROKEN define usage
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Date: Fri, 02 May 2014 03:46:26 -0400
- Subject: Re: [PATCH] Remove PRI_MACROS_BROKEN define usage
- Authentication-results: sourceware.org; auth=none
- References: <532B3168 dot 2030108 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1403201832040 dot 29670 at digraph dot polyomino dot org dot uk> <532B3750 dot 2030102 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1403201848000 dot 29670 at digraph dot polyomino dot org dot uk> <532B3F64 dot 6030005 at linux dot vnet dot ibm dot com>
On 03/20/2014 03:20 PM, Adhemerval Zanella wrote:
> diff --git a/intl/loadmsgcat.c b/intl/loadmsgcat.c
> index b96a997..d47b903 100644
> --- a/intl/loadmsgcat.c
> +++ b/intl/loadmsgcat.c
> @@ -62,6 +62,7 @@ char *alloca ();
> #ifdef _LIBC
> # include <langinfo.h>
> # include <locale.h>
> +# define PRI_MACROS_BROKEN 0
> #endif
>
> #if (defined HAVE_MMAP && defined HAVE_MUNMAP && !defined DISALLOW_MMAP) \
This hunk could go in immediately to fix the -Wundef issues while
take our time to merge a new gettext update.
I was looking at this today, but it's going to be more work than
I have free time for this week.
Even though Steve Ellcey has gotten upstream to change the code
such that PRI_MACROS_BROKEN is always defined, there is no stable
release with that change yet.
Cheers,
Carlos.