This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][BZ 16852] Do not clobber recvmmsg argument.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: mtk dot manpages at gmail dot com
- Cc: David Miller <davem at davemloft dot net>, schwab at linux-m68k dot org, libc-alpha at sourceware dot org
- Date: Wed, 30 Apr 2014 11:07:24 +0200
- Subject: Re: [PATCH v2][BZ 16852] Do not clobber recvmmsg argument.
- Authentication-results: sourceware.org; auth=none
- References: <20140428152937 dot GA1736 at domone dot podge> <87mwf5zcl3 dot fsf at igel dot home> <20140428160420 dot GA23142 at domone dot podge> <20140428 dot 130122 dot 2188782190759376374 dot davem at davemloft dot net> <5360B445 dot 2000408 at gmail dot com>
On Wed, Apr 30, 2014 at 10:28:53AM +0200, Michael Kerrisk (man-pages) wrote:
> On 04/28/2014 07:01 PM, David Miller wrote:
> > From: OndÅej BÃlka <neleai@seznam.cz>
> > Date: Mon, 28 Apr 2014 18:04:20 +0200
> >
> >> * sysdeps/unix/sysv/linux/recvmmsg.c (recvmmsg): Do not clobber
> >> timeout argument.
> >
> > It is extremely unfortunate if we've defined this argument as const,
> > now you are making it so that the user has no mechanism to get the
> > updated timeval other than to define their own syscall stubs.
> >
> > This is doubly unfortunately since there is absolutely no reason for
> > us to have defined the interface different from what the kernel
> > actually provides.
>
> Agreed. Surely, the right fix here is simply to remove the "const"
> qualifier from the glibc API?
>
Now I am also for removing const. Initially I looked to documentation
and this was undocumented feature so I was not sure about it. Could we
also document this in manpages?