This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING^2] RFC [PATCH] BZ#1077902: New API gettimezone
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: P J P <pj dot pandit at yahoo dot co dot in>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Tue, 29 Apr 2014 05:46:22 -0400
- Subject: Re: [PING^2] RFC [PATCH] BZ#1077902: New API gettimezone
- Authentication-results: sourceware.org; auth=none
- References: <1396499286 dot 85118 dot YahooMailNeo at web192405 dot mail dot sg3 dot yahoo dot com> <1397301884 dot 32837 dot YahooMailNeo at web192402 dot mail dot sg3 dot yahoo dot com> <534971E4 dot 6060001 at cs dot ucla dot edu> <53497633 dot 6060804 at redhat dot com> <1397324033 dot 69177 dot YahooMailNeo at web192403 dot mail dot sg3 dot yahoo dot com> <5349A4B0 dot 2070206 at redhat dot com> <1397375798 dot 36419 dot YahooMailNeo at web192401 dot mail dot sg3 dot yahoo dot com> <1397414803 dot 70882 dot YahooMailNeo at web192403 dot mail dot sg3 dot yahoo dot com> <534B8A9F dot 8030806 at redhat dot com> <1397469748 dot 42212 dot YahooMailNeo at web192405 dot mail dot sg3 dot yahoo dot com> <1398146221 dot 72442 dot YahooMailNeo at web192403 dot mail dot sg3 dot yahoo dot com> <1398755742 dot 94004 dot YahooMailNeo at web192405 dot mail dot sg3 dot yahoo dot com>
On 04/29/2014 03:15 AM, P J P wrote:
> Ping!
>
> WRT -> https://bugzilla.redhat.com/show_bug.cgi?id=1077902#c9
>
> - What modifications would we need to the currently submitted patch?
> - Or if we are to go for modifications to tzalloc() routine(s), how do we go about it?
>
> Just checking, for I'm unsure about the details. Any comments/suggestions shall be helpful and welcome.
The current implementation isn't robust in that the POSIX TZ at the end
of the zone file might not be enough to define the timezone completely.
You need to set TZ to a file e.g. TZ=Country/City where possible and
assume in your use-case that the chroot has an updated set of zones
installed that match. You want to use the TZ file format because it allows
a correct implementation by using all the data in the zone files. The POSIX
TZ is insufficient to be correct all the time.
Can you sketch out the tzalloc-style API and propse it?
Cheers,
Carlos.