This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/N, MPX, x86_64] Intel MPX support in glibc for x86_64
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: "Zamyatin, Igor" <igor dot zamyatin at intel dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "hjl dot tools at gmail dot com" <hjl dot tools at gmail dot com>, OndÅej BÃlka <neleai at seznam dot cz>
- Date: Fri, 25 Apr 2014 12:17:19 -0400
- Subject: Re: [PATCH 2/N, MPX, x86_64] Intel MPX support in glibc for x86_64
- Authentication-results: sourceware.org; auth=none
- References: <0EFAB2BDD0F67E4FB6CCC8B9F87D756942973E8E at IRSMSX101 dot ger dot corp dot intel dot com> <5359FBA4 dot 7010203 at redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1404251425350 dot 16509 at digraph dot polyomino dot org dot uk>
On 04/25/2014 10:30 AM, Joseph S. Myers wrote:
> On Fri, 25 Apr 2014, Carlos O'Donell wrote:
>
>> You should test for __int128, set HAVE_INT128, and make this
>> support conditional on the compiler feature being present
>> (avoid hard-coding the compiler version). I believe Ondrej
>> posted a patch for this?
>
> bits/link.h is an installed header so can't contain conditionals on
> configure test results like that.
>
> However, the __int128_t built-in typedef is much older than the __int128
> keyword (dating back to GCC 3.0, i.e. predating x86_64 support which was
> added in 3.1), so that can be used instead.
Agreed. Thanks for catching the fact that this is an installed header.
Cheers,
Carlos.