This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH 2/3] elf/dl-lookup.c: Remove unnecessary static variable
- From: Will Newton <will dot newton at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Fri, 11 Apr 2014 16:29:47 +0100
- Subject: [PATCH 2/3] elf/dl-lookup.c: Remove unnecessary static variable
- Authentication-results: sourceware.org; auth=none
- References: <1397230188-14581-1-git-send-email-will dot newton at linaro dot org>
undefined_msg is only used once contrary to the comment.
ChangeLog:
2014-04-04 Will Newton <will.newton@linaro.org>
* elf/dl-lookup.c (undefined_msg): Remove variable.
(_dl_lookup_symbol_x): Replace undefined_msg with string
literal.
---
elf/dl-lookup.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c
index 896e1d2..1c6ca89 100644
--- a/elf/dl-lookup.c
+++ b/elf/dl-lookup.c
@@ -39,9 +39,6 @@
#define VERSTAG(tag) (DT_NUM + DT_THISPROCNUM + DT_VERSIONTAGIDX (tag))
-/* We need this string more than once. */
-static const char undefined_msg[] = "undefined symbol: ";
-
struct sym_val
{
@@ -817,7 +814,7 @@ _dl_lookup_symbol_x (const char *undef_name, struct link_map *undef_map,
/* XXX We cannot translate the message. */
_dl_signal_cerror (0, DSO_FILENAME (reference_name),
N_("symbol lookup error"),
- make_string (undefined_msg, undef_name,
+ make_string ("undefined symbol: ", undef_name,
versionstr, versionname));
}
*ref = NULL;
--
1.8.1.4