This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING][PATCH] Warn about using _ino_t without -D_FILE_OFFSET_BITS=64.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Paul Eggert <eggert at cs dot ucla dot edu>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 24 Mar 2014 15:01:55 -0700 (PDT)
- Subject: Re: [PING][PATCH] Warn about using _ino_t without -D_FILE_OFFSET_BITS=64.
- Authentication-results: sourceware.org; auth=none
- References: <1393521776-1102-1-git-send-email-reprofy at etersoft dot ru> <530F79C1 dot 2040508 at cs dot ucla dot edu> <20140305091331 dot GA6031 at domone dot podge> <5239512 dot EEmGNsN1rx at vapier> <20140317174452 dot GA10644 at domone> <20140321112938 dot GA15232 at domone dot podge> <Pine dot LNX dot 4 dot 64 dot 1403211228420 dot 1911 at digraph dot polyomino dot org dot uk> <532CADFB dot 6000409 at cs dot ucla dot edu> <20140321220412 dot A5CA3744A7 at topped-with-meat dot com> <532CC581 dot 3070309 at cs dot ucla dot edu>
> That package is free of the problem; my script gave its include files a
> clean bill of health. In fact I'm puzzled why you mentioned it, as its
> include files don't use off_t, off64_t, or any of the other types (with
> or without "64") affected by the problem.
I brought it up because it's a case of a library (libelf) that did have an
API whose ABI was (accidentally) dependent on the _FILE_OFFSET_BITS
setting. The library itself was compiled with -D_FILE_OFFSET_BITS=64 and
so on 32-bit platforms it required that its users be compiled that way too.
We fixed it back in 2007. I misremembered and thought we'd used off64_t.
In fact it uses loff_t. The log entry I wrote at the time said that only
loff_t (not off64_t) was defined by <sys/types.h> in all circumstances.
Thanks,
Roland