This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove PRI_MACROS_BROKEN define usage
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 21 Mar 2014 00:43:55 +0000
- Subject: Re: [PATCH] Remove PRI_MACROS_BROKEN define usage
- Authentication-results: sourceware.org; auth=none
- References: <532B3168 dot 2030108 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1403201832040 dot 29670 at digraph dot polyomino dot org dot uk> <532B3750 dot 2030102 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1403201848000 dot 29670 at digraph dot polyomino dot org dot uk> <532B3F64 dot 6030005 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1403210000380 dot 23226 at digraph dot polyomino dot org dot uk> <532B893B dot 5010709 at linux dot vnet dot ibm dot com>
On Thu, 20 Mar 2014, Adhemerval Zanella wrote:
> > Any change brought from gettext would best be committed on its own
> > (ideally with the original author of that change in gettext being
> > credited).
> >
> The changes I have incorporated on the patch is just change the old K&R
> function prototype to ISO C, remove and superfluous ';' and change a
> free call to remove an unnecessary cast. For these straightforward patches
> do we really need to track the ones how made then and commit a set of
> patches?
You could probably just say "Change merged from gettext." or similar
without detailed attribution - but a change coming from gettext should
still be committed separately from a change not coming from gettext.
--
Joseph S. Myers
joseph@codesourcery.com