This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix -Wundef warnins for __FP_FAST_FMA*


On 03/18/2014 01:07 AM, Siddhesh Poyarekar wrote:
> On Tue, Mar 18, 2014 at 12:38:37AM -0400, Carlos O'Donell wrote:
>> I'm including Roland in this discussion, because I'd like to hear
>> his input.
>>
>> I feel like the correction solution to use a configure check to
>> determine if the compiler defines e.g. __FP_FAST_FMA, and then
>> explicitly define a compiler feature macro as 0 or 1.
> 
> bits/mathdef.h is installed, so using a configure check here would be
> wrong.

In that case as an installed header it would appear that we don't have
much choice but to make these #ifdef. I guess the existing comments about
them being compiler defines is sufficient.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]