This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix -Wundef warnins for __FP_FAST_FMA*
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org, Roland McGrath <roland at hack dot frob dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Tue, 18 Mar 2014 09:58:39 -0400
- Subject: Re: [PATCH] Fix -Wundef warnins for __FP_FAST_FMA*
- Authentication-results: sourceware.org; auth=none
- References: <20140318020544 dot GO1850 at spoyarek dot pnq dot redhat dot com> <5327CDCD dot 6030006 at redhat dot com> <20140318050711 dot GP1850 at spoyarek dot pnq dot redhat dot com>
On 03/18/2014 01:07 AM, Siddhesh Poyarekar wrote:
> On Tue, Mar 18, 2014 at 12:38:37AM -0400, Carlos O'Donell wrote:
>> I'm including Roland in this discussion, because I'd like to hear
>> his input.
>>
>> I feel like the correction solution to use a configure check to
>> determine if the compiler defines e.g. __FP_FAST_FMA, and then
>> explicitly define a compiler feature macro as 0 or 1.
>
> bits/mathdef.h is installed, so using a configure check here would be
> wrong.
In that case as an installed header it would appear that we don't have
much choice but to make these #ifdef. I guess the existing comments about
them being compiler defines is sufficient.
Cheers,
Carlos.