This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Get rid of __LT_SPINLOCK_INIT
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Mon, 17 Mar 2014 12:31:18 -0300
- Subject: Re: [PATCH] Get rid of __LT_SPINLOCK_INIT
- Authentication-results: sourceware.org; auth=none
- References: <20140317135545 dot GM1850 at spoyarek dot pnq dot redhat dot com> <CANu=DmjdkLPDOv1eT94ETnG3pq2ne8HpQaeNP9DP6K6rXKQzkA at mail dot gmail dot com>
On 17-03-2014 12:18, Will Newton wrote:
> On 17 March 2014 13:55, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
>
> Hi Siddesh,
>
>> We got rid of LinuxThreads in 2005, but we didn't remove
>> __LT_SPINLOCK_INIT back then. Do it now.
> This looks straightforward, however it seems the only arch that ever
> set __LT_SPINLOCK_INIT was hppa, so I assume this conditional was
> meant once upon a time to do something for hppa. I guess the patch is
> fine (as it does not change existing behaviour) but maybe someone who
> cares about hppa should verify that something isn't needed for that
> arch here.
>
Carlos O'Donnel is the maintainer for hppa. However, if you ever check on
GLIBC (a simple grep), you will see __LT_SPINLOCK_INIT is never defined in
any arch config file and it was only defined by when glibc used linuxpthread.
So I think it safe to just get rid of it.