This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] S/390:
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 14 Mar 2014 14:18:23 +0000
- Subject: Re: [PATCH] S/390:
- Authentication-results: sourceware.org; auth=none
- References: <lfuu4e$uam$3 at ger dot gmane dot org>
On Fri, 14 Mar 2014, Stefan Liebler wrote:
> Hi,
>
> The conformance tests for ISO99, ISO11, XOPEN2K, POSIX2008 and XOPEN2K8
> are failing on S390 for the inttypes.h and stdint.h headers.
> The problem is that on S390 size_t / __SIZE_TYPE__
> are defined as long unsigned int,
> which has the same size as unsigned int (on S390).
> SIZE_MAX is defined in sysdeps/generic/stdint.h as 4294967295U.
> The conformance-test checks the type of SIZE_MAX,
> which should be promoted to __SIZE_TYPE__, but it is unsigned int.
You should fix the header rather than marking these tests as expected to
fail. (Of course, file a bug in Bugzilla before fixing it, as usual.) To
avoid duplicating the whole header, maybe add a macro <bits/wordsize.h>
can define such as __WORDSIZE32_SIZE_ULONG, and then test that macro in
<stdint.h>.
(You have two identical bits/wordsize.h files for S/390. Just one should
suffice.)
--
Joseph S. Myers
joseph@codesourcery.com