This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Fix offset caching for streams and use it for ftell (BZ #16680)
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Rich Felker <dalias at aerifal dot cx>
- Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 12 Mar 2014 23:54:33 +0530
- Subject: Re: [PATCH v2] Fix offset caching for streams and use it for ftell (BZ #16680)
- Authentication-results: sourceware.org; auth=none
- References: <20140311124615 dot GA2182 at spoyarek dot pnq dot redhat dot com> <20140312181042 dot GB1850 at spoyarek dot pnq dot redhat dot com> <20140312181803 dot GS184 at brightrain dot aerifal dot cx>
On 12 March 2014 23:48, Rich Felker <dalias@aerifal.cx> wrote:
> At least one line in yout table is wrong: ftell can never change the
> offset when the handle is inactive. You have it changing the offset in
> this case for append-mode files. I don't see why you want to do this.
Thanks for pointing that out. I was supposed to add a note there
clarifying that it's fopen/fdopen that does the offset change there
and I forgot to do that. I've updated the document now to hopefully
be a bit clearer.
Siddhesh
--
http://siddhesh.in