This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Inline useless nested function mi_arena.


On Thu, Feb 27, 2014 at 01:27:51AM -0500, Carlos O'Donell wrote:
> On 02/26/2014 04:49 PM, OndÅej BÃlka wrote:
> > Hi,
> > 
> > I noticed a minor simplification in malloc_info, that nested function
> > mi_arena looks useless as it gets called at only one site and I do not
> > have to rename its argument. The resulting patch is big due of
> > reindenting but is simple in principle.
> > 
> > Is there any deep reason to keep it?
> 
> Having the per-arena malloc_info actions broken out into a
> logical block makes the malloc_info code easier to read 
> and understand.
> 
Its block of code problem is how much is logical put it into separate
function.

> > 	* malloc/malloc.c (malloc_info): Inline mi_arena.
> 
> Make it a real function please? That way the generated debug
> information is better.
> 
> Cheers,
> Carlos.

-- 

global warming


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]