This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH roland/Wundef] Compile with -Wundef.

From: Thomas Schwinge <thomas at codesourcery dot com>
To: Roland McGrath <roland at hack dot frob dot com>
Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
Date: Mon, 3 Mar 2014 10:02:51 +0100
Subject: Re: [PATCH roland/Wundef] Compile with -Wundef.
Authentication-results: sourceware.org; auth=none
References: <20140228232805 dot 1163D744B4 at topped-with-meat dot com>

Hi!

On Fri, 28 Feb 2014 15:28:05 -0800 (PST), Roland McGrath <roland@hack.frob.com> wrote:
> --- a/sysdeps/mach/hurd/i386/tls.h
> +++ b/sysdeps/mach/hurd/i386/tls.h
> @@ -26,6 +26,7 @@
>  /* The TCB can have any size and the memory following the address the
>     thread pointer points to is unspecified.  Allocate the TCB there.  */
>  #define TLS_TCB_AT_TP	1
> +#define TLS_TCB_AT_TP	0

:-) Hmm?  (Should that have been TLS_DTV_AT_TP, I think?)

Also, not relevant for Hurd but for NPTL: don't all Â#ifdef
TLS_TCB_AT_TPÂ need to be adapted now?  And, all the instances of Â#error
"Either TLS_TCB_AT_TP or TLS_DTV_AT_TP must be defined"Â are not longer
appropriate in this wording, too.

Generally, of course, thumbs up for stricter compile-time checks.

GrÃÃe,
 Thomas

Attachment: pgpCdz9kI3Qr6.pgp
Description: PGP signature

Follow-Ups:
- Re: [PATCH roland/Wundef] Compile with -Wundef.
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]