This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMITTED PATCH] Fix fallout from Joseph's untested Makeconfig change.


On Fri, 28 Feb 2014, Joseph S. Myers wrote:

> I did the audit (for variables using += in Makeconfig, as those seemed to 
> be the cases where things could have worked with a late include of 
> Makeconfig but not an early one) when Stefan Liebler pointed out the 
> problem.  That's how I identified the other directories with similarly 
> affected includes of before-compile in 
> <https://sourceware.org/ml/libc-alpha/2014-02/msg00771.html> - albeit that 
> those settings of before-compile weren't in a position for which my patch 
> made any difference.  I now see this audit missed files included by 
> Makeconfig (config.make configparms $(sysdep-makeconfigs) sysd-sorted 
> soversions.mk); on the basis that configparms has no business defining 
> anything for which this could be relevant, I don't see any affected 
> variables in those files either.

And having reviewed the settings of other variables, I don't see anything 
much relevant there either - just the previously noted before-compile 
setting in posix/ that was unchanged by your patch but also unaffected by 
mine, and INSTALL_INFO in manual/Makefile (patch below, tested x86_64 
build and "make install").

* Makeconfig defines asm-CPPFLAGS as does csu/Makefile, but the former is 
inside "ifndef asm-CPPFLAGS" and the latter uses +=.

* Makeconfig and elf/Makefile define CPPFLAGS-.os but the latter uses += 
and my patch doesn't change elf/Makefile anyway.

* iconvdata/Makefile appends to CPPFLAGS, but after both include locations 
for Makeconfig.  Likewise inet/Makefile appending to CFLAGS.  Likewise 
intl/Makefile appending to CPPFLAGS.  Likewise libio/Makefile appending to 
CPPFLAGS.  Likewise math/Makefile appending to CFLAGS.  Likewise 
nptl/Makefile replacing link-libc-static.  Likewise resolv/Makefile 
appending to CPPFLAGS and +cflags.  Likewise sunrpc/Makefile appending to 
CPPFLAGS.  Likewise wcsmbs/Makefile appending to CPPFLAGS.

* mach/Makefile defines mach-interface-list, overriding config.make.in, 
but the Makeconfig include location is completely unchanged there.

2014-02-28  Joseph Myers  <joseph@codesourcery.com>

	* manual/Makefile (INSTALL_INFO): Remove variable setting.

diff --git a/manual/Makefile b/manual/Makefile
index ec1f3d8..62217a2 100644
--- a/manual/Makefile
+++ b/manual/Makefile
@@ -21,9 +21,6 @@ subdir := manual
 
 include ../Makeconfig
 
-# Allow override
-INSTALL_INFO = install-info
-
 .PHONY: dvi pdf info html
 
 dvi: $(objpfx)libc.dvi

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]