This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch, mips] Add new inline functions to mips math_private.h
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Steve Ellcey <sellcey at mips dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 25 Feb 2014 22:12:17 +0000
- Subject: Re: [patch, mips] Add new inline functions to mips math_private.h
- Authentication-results: sourceware.org; auth=none
- References: <1393355427 dot 14836 dot 58 dot camel at ubuntu-sellcey>
On Tue, 25 Feb 2014, Steve Ellcey wrote:
> This is a patch to the MIPS math_private.h file to define HAVE_RM_CTX and
> implement the ctx macros. I also defined a few other macros and inline
> functions that I skipped the first time.
>
> Testing did not show any correctness regressions and I got some performance
> improvements plus a few small regressions. I included a before and after
> bench.out file along with the patch. Some tests slowed down but log2() was
> the only one that slowed down more then 1%. 5 tests improved by about 2.5%,
> cosh improved by 11.55%, sinh by 7.8%, and sincos() by 10%. I think the
> sinh/cosh improvements being larger are due to simple/small inputs in the
> test cases.
>
> I am not completely sure about the difference between the libc_feholdsetround
> functions and the libc_feholdexcept_setround functions (likewise
> libc_feupdateenv and libc_feresetround), but I believe my changes are safe,
> even if they may not be optimal. If anyone has any comments on these in
> particular I would like to hear them.
>
> OK to checkin?
OK.
--
Joseph S. Myers
joseph@codesourcery.com