This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix sign of input to bsloww1 (BZ #16623)
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>, libc-alpha at sourceware dot org, Allan McRae <allan at archlinux dot org>
- Date: Tue, 25 Feb 2014 12:01:36 -0500
- Subject: Re: [PATCH] Fix sign of input to bsloww1 (BZ #16623)
- Authentication-results: sourceware.org; auth=none
- References: <20140225091656 dot GH9254 at spoyarek dot pnq dot redhat dot com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/25/2014 04:16 AM, Siddhesh Poyarekar wrote:
> Hi,
>
> In 84ba214c, I removed some redundant sign computations and in the
> process, I incorrectly got rid of a temporary variable, thus passing
> the absolute value of the input to bsloww1. This caused #16623.
>
> This fix undoes the incorrect change. Added test case inputs and
> regenerated aut-libm-test-out and ULPs for x86_64. Verified that this
> does not cause regressions in the math testsuite on x86_64.
>
> OK to commit?
>
> Siddhesh
>
> [BZ #16623]
> * math/auto-libm-test-in: New test inputs.
> * math/auto-libm-test-out: Regenerate.
> * sysdeps/ieee754/dbl-64/s_sin.c (__sin): Preserve sign of A
> and DA.
> (__cos): Likewise.
> * sysdeps/x86_64/fpu/libm-test-ulps: Regenerate.
Looks good to me.
I assume we want this backported to 2.19?
Looks good to me there too. Allan should ACK.
Cheers,
Carlos.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTDMxwAAoJECXvCkNsKkr/EPoIAJLpbO1Jx0urNTCbAw8hZYsG
XXHLM4krY+bc370xR76Vyh2WB5/EthjdrpaJgpOBnE7UeWO2PWBfW8MNt4KMlkUL
cDTP8GbsuhdtXfkRFFpM7UCA0zNBDqe6T8qsj5Htm7kl3d4ostNntXyhuBofnMCn
H2ClhA2Q3cSr33K7Y9LjxOsSvwsfSyLvAb4+Kdge5AExBCG2HxrGxdvXs1TGuQvl
QEzD2trJKxLOBqdwY8mpkmXee+nWP03RWmqzMkfgPEP/j7o/V+/k1S8Cbg4dKC97
QP665WdFIUGBA/SfyGq5edf5yVMiJCjYw429BQV53wRNnIm05VOGsIZs+nYffv8=
=3iaT
-----END PGP SIGNATURE-----