This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix __ASSUME_RECVMMSG issues (bug 16610)
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Cc: Chris Metcalf <cmetcalf at tilera dot com>
- Date: Thu, 20 Feb 2014 11:46:42 -0500
- Subject: Re: Fix __ASSUME_RECVMMSG issues (bug 16610)
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1402200038330 dot 5004 at digraph dot polyomino dot org dot uk>
On 02/19/2014 07:42 PM, Joseph S. Myers wrote:
> Similar to the issues for accept4, __ASSUME_RECVMMSG is also confused
> about whether it relates to function availability or socketcall
> operation availability; this is now bug 16610.
Thanks for fixing these.
> Architecture-specific note: Tile's kernel-features.h says "TILE glibc
> support starts with 2.6.36", which is accurate in that 2.6.36 was the
> first kernel version with Tile support, and on that basis I've made
> that header define __ASSUME_RECVMMSG_SYSCALL unconditionally.
> However, Tile's configure.ac has arch_minimum_kernel=2.6.32. Since
> arch_minimum_kernel is meant to reflect only kernel.org kernel
> versions, I think that should change to 2.6.36. (If using glibc with
> kernel versions from before a port went in kernel.org, it's your
> responsibility to change arch_minimum_kernel in a local patch, and at
> the same time to adjust any __ASSUME_* definitions that may not be
> correct for your older kernel; for developing the official glibc it
> should only ever be necessary to consider what official kernel.org
> releases support.)
Only Chris can answer this one.
> Tested x86_64, including that disassembly of the installed shared
> libraries is unchanged by this patch.
This also looks good to me.
Cheers,
Carlos.