This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Deduplicate resolv/nss_dns/dns-host.c

From: Mike Frysinger <vapier at gentoo dot org>
To: libc-alpha at sourceware dot org
Cc: OndÅej BÃlka <neleai at seznam dot cz>
Date: Fri, 14 Feb 2014 12:25:51 -0500
Subject: Re: [PATCH] Deduplicate resolv/nss_dns/dns-host.c
Authentication-results: sourceware.org; auth=none
References: <20140213123812 dot GB14778 at domone dot podge>

On Thursday, February 13, 2014 13:38:12 OndÅej BÃlka wrote:
> Hi, when reviewing Andreas patch I noticed duplicated code. One way to
> improve that is jump to exit logic. A second possibility would be put
>  gaih_getanswer into a else block. What do you prefer?

i don't mind either, but i think generally the preference is to avoid goto 
when easily possible.  so in this case, use the else.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Follow-Ups:
- [PATCH v1.1] Deduplicate resolv/nss_dns/dns-host.c
  - From: OndÅej BÃlka

References:
- [PATCH] Deduplicate resolv/nss_dns/dns-host.c
  - From: OndÅej BÃlka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]