This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2.19] S/390: Make ucontext_t extendible - update
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 22 Jan 2014 17:09:05 +0000
- Subject: Re: [PATCH 2.19] S/390: Make ucontext_t extendible - update
- Authentication-results: sourceware.org; auth=none
- References: <20140103154754 dot GB30732 at bart> <Pine dot LNX dot 4 dot 64 dot 1401220259300 dot 25161 at digraph dot polyomino dot org dot uk> <20140122150840 dot GA22572 at bart>
On Wed, 22 Jan 2014, Andreas Krebbel wrote:
> On Wed, Jan 22, 2014 at 03:23:59AM +0000, Joseph S. Myers wrote:
> > On Fri, 3 Jan 2014, Andreas Krebbel wrote:
> >
> > > * sysdeps/unix/sysv/linux/s390/sys/ucontext.h: Split into 32 and
> > > 64 bit versions:
> >
> > I've just noticed this change. Splitting a header like this is a bad
> > idea: the same set of installed headers should be usable for multilib
> > configurations, meaning that headers should contain 32-bit/64-bit
> > preprocessor conditionals instead of having different versions of the
> > header installed for different glibc configurations on the same
> > architecture.
>
> Ok to apply this patch?
I haven't reviewed the details, but it does the sort of thing I'd expect.
> diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/ucontext_i.sym b/sysdeps/unix/sysv/linux/s390/s390-32/ucontext_i.sym
> index 705c7ab..ce3c688 100644
> --- a/sysdeps/unix/sysv/linux/s390/s390-32/ucontext_i.sym
> +++ b/sysdeps/unix/sysv/linux/s390/s390-32/ucontext_i.sym
> @@ -23,4 +23,6 @@ SC_ACRS mcontext (aregs)
> SC_FPC mcontext (fpregs.fpc)
> SC_FPRS mcontext (fpregs.fprs)
> SC_MASK ucontext (uc_sigmask)
> +#ifndef __s390x__
> SC_HIGHGPRS ucontext (uc_high_gprs)
> +#endif
I don't see such a conditional as being needed in a file in the s390-32
directory.
--
Joseph S. Myers
joseph@codesourcery.com