This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ptrace.h: add __ prefix to ptrace_peeksiginfo_args


On 06/01/14 08:17, Mike Frysinger wrote:
> On Sunday 05 January 2014 16:10:44 Mike Frysinger wrote:
>> All the other ptrace structures in this file have a __ prefix except this
>> new one.  This in turn causes build problems for most packages that try to
>> use ptrace such as strace:
>>
>> gcc -DHAVE_CONFIG_H -I. -I../..  -I../../linux/x86_64 -I../../linux \
>> 	-I./linux  -Wall -Wwrite-strings -g -O2 -MT process.o -MD -MP \
>> 	-MF .deps/process.Tpo -c -o process.o ../../process.c
>> In file included from ../../process.c:63:0:
>> /usr/include/linux/ptrace.h:58:8: error: redefinition of 'struct
>> ptrace_peeksiginfo_args' struct ptrace_peeksiginfo_args {
>>         ^
>> In file included from ../../defs.h:159:0,
>>                  from ../../process.c:37:
>> /usr/include/sys/ptrace.h:191:8: note: originally defined here
>>  struct ptrace_peeksiginfo_args
>>         ^
>>
>> Since this struct was introduced in glibc-2.18, there shouldn't be any
>> real regressions with adding the __ prefix.
> 
> i'd like to include this for glibc-2.19 (and cherry pick to glibc-2.18) since 
> it causes troubles for people building ptrace apps

Fine for 2.19.

Allan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]