This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING^2][PATCH] Reformat malloc to gnu style.


On Thu, Jan 02, 2014 at 04:28:18PM +0000, Joseph S. Myers wrote:
> Several of the changes committed in commit 
> 6c8dbf00f536d78b1937b5af6f57be47fd376344 are wrong - sufficiently many 
> that I think it should be reverted, and then smaller patches submitted 
> after the freeze each of which addresses exactly one formatting issue 
> (e.g. bad indentation), everywhere it occurs (or only some places it 
> occurs, if needed to keep the patch below 1000 lines).  For example:
> 
That is missing a point, a formatting now was wastly different than gnu
one so goal was not get perfect on first try but to converge to
solution.

In formatting patches there are three factors in play:

1) Amount of code formatted correctly.
2) Amount of code left intact.
3) Amount of code formatted incorrectly.

Now factors 2 and 3 sum to amount of code that needs futher formatting.
If a formatter gets 95% of code right then you need to fix only 5% of
code which means that patches that fix these are twenty times smaller
than in first case.

For our purposes it is mostly irrelevant if flaw was caused by formatter
or left over unless formatting causes loss of informattion. Where a style 
allows only one possibility you cannot encode any information so that is
not a factor.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]