This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix typo in csloww()
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Allan McRae <allan at archlinux dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 26 Dec 2013 17:58:06 +0530
- Subject: Re: [PATCH] Fix typo in csloww()
- Authentication-results: sourceware.org; auth=none
- References: <1388060194-25678-1-git-send-email-allan at archlinux dot org>
On Thu, Dec 26, 2013 at 10:16:34PM +1000, Allan McRae wrote:
> An incorrect variable name was used during the refactoring done in
> commit 4aafb73c.
> ---
> sysdeps/ieee754/dbl-64/s_sin.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> Posting to confirm this is as obvious as it appears!
Oh yes, thanks for catching that :)
It would surely help if there's an input that catches this typo so
that we can add it to the testsuite.
Siddhesh
>
>
> ChangeLog:
>
> 2013-12-xx Allan McRae <allan@archlinux.org>
>
> [BZ #16369]
> * sysdeps/ieee754/dbl-64/s_sin.c (csloww): Fix variable name.
> Reported by Il'ya Malakhov <ilmalakhov@yandex.ru>
>
>
> diff --git a/sysdeps/ieee754/dbl-64/s_sin.c b/sysdeps/ieee754/dbl-64/s_sin.c
> index bd2346c..edc4415 100644
> --- a/sysdeps/ieee754/dbl-64/s_sin.c
> +++ b/sysdeps/ieee754/dbl-64/s_sin.c
> @@ -1102,7 +1102,7 @@ csloww (double x, double dx, double orig)
> int4 n;
>
> /* Taylor series */
> - t = TAYLOR_SLOW (x, dx, cor);
> + res = TAYLOR_SLOW (x, dx, cor);
>
> if (cor > 0)
> cor = 1.0005 * cor + ABS (orig) * 3.1e-30;
> --
> 1.8.5.2
>