This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/4] Add a signal-safe malloc replacement
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Paul Pluzhnikov <ppluzhnikov at google dot com>, Andrew Hunter <ahh at google dot com>, GNU C Library <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>
- Date: Thu, 19 Dec 2013 18:40:11 +0100
- Subject: Re: [PATCH 2/4] Add a signal-safe malloc replacement
- Authentication-results: sourceware.org; auth=none
- References: <1386273671-13010-1-git-send-email-ahh at google dot com> <1386722143-10513-1-git-send-email-ahh at google dot com> <1386722143-10513-2-git-send-email-ahh at google dot com> <20131211100309 dot GA24512 at domone dot podge> <CALoOobMKYyD7G7fbYHq2aqx32S_QMs19DZY2YhJ-JA4_d4717A at mail dot gmail dot com> <CADroS=7LJ4uKGB30jsNn2xV5Dxr7eZ24H3NScHUCYWORUnMTfQ at mail dot gmail dot com> <CALoOobP0xGCB_6Vf9uTizqctJP1r9aW2eRoBFNeaHHASWd75mg at mail dot gmail dot com> <CALoOobOT_os7AuCB+_+fy+u9LOaRajBLoQKgf20vKeqYTxRJhg at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1312191656360 dot 8877 at digraph dot polyomino dot org dot uk>
On Thu, Dec 19, 2013 at 04:58:46PM +0000, Joseph S. Myers wrote:
> I see build warnings on x86_64:
>
> dl-misc.c:391:3: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
> dl-misc.c:435:14: warning: assignment from incompatible pointer type [enabled by default]
> dl-misc.c: In function '__signal_safe_free':
> dl-misc.c:459:51: warning: initialization from incompatible pointer type [enabled by default]
> dl-misc.c: In function '__signal_safe_realloc':
> dl-misc.c:476:51: warning: initialization from incompatible pointer type [enabled by default]
>
> Please check for new warnings arising from patches and try to keep the
> build warning-free. (I'd quite like to use -Werror so you don't need to
> check manually for warnings, but that would require working out a standard
> approach for the cases where warnings are hard to fix, possibly arising
> from compiler bugs and possibly architecture-dependent.)
>
One possible approach would be have a warning subsection in Makefile like:
# gcc gets false positive on line 42
CFLAGS-foo.c += -Wno-error=bar
For these somebody would need first check warnings for given
architecture and gcc version and then enable -Werror for these pairs. Then for each
gcc release check new warnings.
Last step could be automated by cron job which weekly does something like
get_latest_gcc
cd week_old_glibc; make 2> a
cd new_glibc; make 2> b
diff a b > c
if [ ! -z "`cat c`" ]
mail c
fi