This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/4] Add a signal-safe malloc replacement


On Thu, Dec 19, 2013 at 04:58:46PM +0000, Joseph S. Myers wrote:
> I see build warnings on x86_64:
> 
> dl-misc.c:391:3: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
> dl-misc.c:435:14: warning: assignment from incompatible pointer type [enabled by default]
> dl-misc.c: In function '__signal_safe_free':
> dl-misc.c:459:51: warning: initialization from incompatible pointer type [enabled by default]
> dl-misc.c: In function '__signal_safe_realloc':
> dl-misc.c:476:51: warning: initialization from incompatible pointer type [enabled by default]
> 
> Please check for new warnings arising from patches and try to keep the 
> build warning-free.  (I'd quite like to use -Werror so you don't need to 
> check manually for warnings, but that would require working out a standard 
> approach for the cases where warnings are hard to fix, possibly arising 
> from compiler bugs and possibly architecture-dependent.)
> 
One possible approach would be have a warning subsection in Makefile like:

# gcc gets false positive on line 42
CFLAGS-foo.c += -Wno-error=bar

For these somebody would need first check warnings for given
architecture and gcc version and then enable -Werror for these pairs. Then for each
gcc release check new warnings.

Last step could be automated by cron job which weekly does something like

get_latest_gcc
cd week_old_glibc; make 2> a
cd new_glibc; make 2> b
diff a b > c
if [ ! -z "`cat c`" ]
  mail c
fi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]