This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Simplify perturb_byte logic.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Paul Eggert <eggert at cs dot ucla dot edu>
- Cc: Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
- Date: Thu, 12 Dec 2013 01:26:24 +0100
- Subject: Re: [PATCH] Simplify perturb_byte logic.
- Authentication-results: sourceware.org; auth=none
- References: <20131209141613 dot GA15247 at domone dot podge> <52A5E9E3 dot 4020505 at cs dot ucla dot edu> <20131209162724 dot GA30871 at domone dot podge> <20131211233843 dot BD74A7442B at topped-with-meat dot com> <52A8FCA7 dot 1080001 at cs dot ucla dot edu>
On Wed, Dec 11, 2013 at 04:00:39PM -0800, Paul Eggert wrote:
> Roland McGrath wrote:
> > I thought we now had a
> > convention not to use the 'inline' keyword on static functions.
>
> Sorry, I missed that. Yes, alloc_perturb and free_perturb
> should just be static.
Should be always_inline, for macros converted to function otherwise we
could degrade performance.