Re: [PATCH 03/19] PowerPC: multiarch memcmp for PowerPC32

["Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>]

I have only a pedantic comment.
In overall the patches 01-03 look fine.

Adhemerval Zanella <azanella@linux.vnet.ibm.com> writes:
> diff --git a/sysdeps/powerpc/powerpc32/power4/multiarch/Makefile 
> b/sysdeps/powerpc/powerpc32/power4/multiarch/Makefile
> index 79ef7c7..ac7df08 100644
> --- a/sysdeps/powerpc/powerpc32/power4/multiarch/Makefile
> +++ b/sysdeps/powerpc/powerpc32/power4/multiarch/Makefile
> @@ -1,4 +1,4 @@
>  ifeq ($(subdir),string)
>  sysdep_routines += memcpy-power7 memcpy-a2 memcpy-power6 
>  memcpy-cell \
> -		   memcpy-ppc32
> +		   memcpy-ppc32 memcmp-power7 memcmp-ppc32
>  endif

This seems to be missing a space.

> diff --git 
> a/sysdeps/powerpc/powerpc32/power4/multiarch/ifunc-impl-list.c 
> b/sysdeps/powerpc/powerpc32/power4/multiarch/ifunc-impl-list.c
> index 470439f..a4ff4c3 100644
> --- 
> a/sysdeps/powerpc/powerpc32/power4/multiarch/ifunc-impl-list.c
> +++ 
> b/sysdeps/powerpc/powerpc32/power4/multiarch/ifunc-impl-list.c
> @@ -60,5 +60,11 @@ __libc_ifunc_impl_list (const char *name, 
> struct libc_ifunc_impl *array,
>  	      IFUNC_IMPL_ADD (array, i, memcpy, 1, __memcpy_ppc))
>  #endif
>
> +  /* Support 
> sysdeps/powerpc/powerpc32/power4/multiarch/memcmp.c.  */
> +  IFUNC_IMPL (i, name, memcmp,
> +	      IFUNC_IMPL_ADD (array, i, memcmp, hwcap & 
> PPC_FEATURE_HAS_VSX,
> +			      __memcmp_power7)
> +	      IFUNC_IMPL_ADD (array, i, memcmp, 1, __memcmp_ppc))
> +
>    return i;
>  }

Same thing.

--
Tulio Magno