This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use unused.0 instead of unused for user visible struct members

From: OndÅej BÃlka <neleai at seznam dot cz>
To: Justin Cormack <justin at specialbusservice dot com>
Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
Date: Tue, 5 Nov 2013 14:54:04 +0100
Subject: Re: [PATCH] Use __unused.0 instead of __unused for user visible struct members
Authentication-results: sourceware.org; auth=none
References: <CAK4o1WzkMk8nV2jzM38peutbMWuKBPTeh5dbfwSiDhankAT=Yw at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1310281328500 dot 25699 at digraph dot polyomino dot org dot uk> <CAK4o1WxO9=qbKUiJtZtS+Q9Wyo8EfNrO_H8=J_w=zcQP822Dvw at mail dot gmail dot com>

On Mon, Oct 28, 2013 at 03:41:18PM +0000, Justin Cormack wrote:
> On Mon, Oct 28, 2013 at 1:30 PM, Joseph S. Myers
> <joseph@codesourcery.com> wrote:
> > On Mon, 28 Oct 2013, Justin Cormack wrote:
> >
> >> A patch was submitted for this a while back
> >> https://sourceware.org/ml/libc-alpha/2012-01/msg00001.html and did not
> >> get a good reception from the maintainer at the time. Attached is an
> >> updated version for current glibc head.
> >
> > I believe we had consensus on use of __glibc_reserved as a prefix in such
> > cases (allowing for __glibc_reserved0, __glibc_reserved1 or
> > __glibc_reserved_foo, __glibc_reserved_bar in cases where more than one
> > identifier, or a more meaningful name, is needed).
> 
> OK, that makes sense, found part of that conversation in the archives.
> Here is a patch (inline and attached) to convert all uses to
> __glibc_reserved.
> 
> Justin
>
A mechanical change that looks ok,

It needs changelog so I generated following.

./nptl/ChangeLog:


	* sysdeps/i386/tls.h: Use __glibc_reserved instead __unused.
	* sysdeps/x86_64/tls.h: Likewise.
	* sysdeps/i386/tls.h: Likewise.
	* sysdeps/x86_64/tls.h: Likewise.

./ChangeLog:


	* resolv/netdb.h: Use __glibc_reserved instead __unused..
	* rt/aio.h: Likewise.
	* sysdeps/gnu/bits/utmp.h: Likewise.
	* sysdeps/gnu/bits/utmpx.h: Likewise.
	* sysdeps/gnu/netinet/ip_icmp.h: Likewise.
	* sysdeps/unix/sysv/linux/bits/ipc.h: Likewise.
	* sysdeps/unix/sysv/linux/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/bits/stat.h: Likewise.
	* sysdeps/unix/sysv/linux/kernel_stat.h: Likewise.
	* sysdeps/unix/sysv/linux/ntp_gettimex.c: Likewise.
	* sysdeps/unix/sysv/linux/powerpc/bits/ipc.h: Likewise.
	* sysdeps/unix/sysv/linux/powerpc/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/powerpc/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/powerpc/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/powerpc/bits/stat.h: Likewise.
	* sysdeps/unix/sysv/linux/powerpc/powerpc32/kernel_stat.h: Likewise.
	* sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h: Likewise.
	* sysdeps/unix/sysv/linux/s390/bits/ipc.h: Likewise.
	* sysdeps/unix/sysv/linux/s390/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/s390/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/s390/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/s390/bits/stat.h: Likewise.
	* sysdeps/unix/sysv/linux/s390/bits/utmp.h: Likewise.
	* sysdeps/unix/sysv/linux/s390/bits/utmpx.h: Likewise.
	* sysdeps/unix/sysv/linux/s390/s390-32/utmp32.h: Likewise.
	* sysdeps/unix/sysv/linux/s390/s390-32/utmpx32.h: Likewise.
	* sysdeps/unix/sysv/linux/sh/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/sparc/bits/fcntl.h: Likewise.
	* sysdeps/unix/sysv/linux/sparc/bits/ipc.h: Likewise.
	* sysdeps/unix/sysv/linux/sparc/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/sparc/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/sparc/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/sparc/bits/stat.h: Likewise.
	* sysdeps/unix/sysv/linux/sparc/sparc32/kernel_stat.h: Likewise.
	* sysdeps/unix/sysv/linux/sparc/sparc64/kernel_stat.h: Likewise.
	* sysdeps/unix/sysv/linux/sparc/sparc64/xstatconv.c: Likewise.
	* sysdeps/unix/sysv/linux/sparc/sys/procfs.h: Likewise.
	* sysdeps/unix/sysv/linux/sys/timex.h: Likewise.
	* sysdeps/unix/sysv/linux/x86/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/x86/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/x86/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/x86/bits/stat.h: Likewise.
	* sysdeps/unix/sysv/linux/xstatconv.c: Likewise.
	* sysdeps/x86/fpu/bits/fenv.h: Likewise.

./ports/ChangeLog.ia64:


	* sysdeps/unix/sysv/linux/ia64/bits/ipc.h: Use __glibc_reserved instead __unused.
	* sysdeps/unix/sysv/linux/ia64/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/ia64/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/ia64/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/ia64/bits/stat.h: Likewise.
	* sysdeps/unix/sysv/linux/ia64/bits/ipc.h: Likewise.
	* sysdeps/unix/sysv/linux/ia64/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/ia64/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/ia64/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/ia64/bits/stat.h: Likewise.

./ports/ChangeLog.alpha:


	* sysdeps/unix/sysv/linux/alpha/bits/ipc.h: Use __glibc_reserved instead __unused.
	* sysdeps/unix/sysv/linux/alpha/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/alpha/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/alpha/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/alpha/bits/stat.h: Likewise.
	* sysdeps/unix/sysv/linux/alpha/kernel_stat.h: Likewise.
	* sysdeps/unix/sysv/linux/alpha/xstatconv.c: Likewise.
	* sysdeps/unix/sysv/linux/alpha/bits/ipc.h: Likewise.
	* sysdeps/unix/sysv/linux/alpha/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/alpha/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/alpha/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/alpha/bits/stat.h: Likewise.
	* sysdeps/unix/sysv/linux/alpha/kernel_stat.h: Likewise.
	* sysdeps/unix/sysv/linux/alpha/xstatconv.c: Likewise.

./ports/ChangeLog.unix:


	* sysdeps/unix/sysv/linux/generic/bits/msq.h: Use __glibc_reserved instead __unused.
	* sysdeps/unix/sysv/linux/generic/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/generic/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/generic/bits/stat.h: Likewise.
	* sysdeps/unix/sysv/linux/generic/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/generic/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/generic/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/generic/bits/stat.h: Likewise.

./ports/ChangeLog.mips:


	* sysdeps/unix/sysv/linux/mips/bits/ipc.h: Use __glibc_reserved instead __unused..
	* sysdeps/unix/sysv/linux/mips/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/mips/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/mips/bits/shm.h: Likewise.

./ports/ChangeLog.microblaze:


	* sysdeps/unix/sysv/linux/microblaze/bits/stat.h: Use __glibc_reserved instead __unused..
	* sysdeps/unix/sysv/linux/microblaze/kernel_stat.h: Likewise.

./ports/ChangeLog.hppa:


	* sysdeps/unix/sysv/linux/hppa/bits/ipc.h: Use __glibc_reserved instead __unused.
	* sysdeps/unix/sysv/linux/hppa/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/hppa/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/hppa/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/hppa/kernel_stat.h: Likewise.
	* sysdeps/unix/sysv/linux/hppa/bits/ipc.h: Likewise.
	* sysdeps/unix/sysv/linux/hppa/bits/msq.h: Likewise.
	* sysdeps/unix/sysv/linux/hppa/bits/sem.h: Likewise.
	* sysdeps/unix/sysv/linux/hppa/bits/shm.h: Likewise.
	* sysdeps/unix/sysv/linux/hppa/kernel_stat.h: Likewise.

./ports/ChangeLog.m68k:


	* sysdeps/unix/sysv/linux/m68k/bits/stat.h: Use __glibc_reserved instead __unused.
	* sysdeps/unix/sysv/linux/m68k/bits/stat.h: Likewise.

./ports/ChangeLog.arm:


	* sysdeps/unix/sysv/linux/arm/bits/shm.h: Use __glibc_reserved instead __unused.
	* sysdeps/unix/sysv/linux/arm/bits/shm.h: Likewise.

Follow-Ups:
- Re: [PATCH] Use __unused.0 instead of __unused for user visible struct members
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] Use __unused.0 instead of __unused for user visible struct members

Re: [PATCH] Use unused.0 instead of unused for user visible struct members