This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use __glibc_(un)likely instead __builtin_expect.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 23 Oct 2013 12:17:13 +0200
- Subject: Re: [PATCH] Use __glibc_(un)likely instead __builtin_expect.
- Authentication-results: sourceware.org; auth=none
- References: <20131022220131 dot GA30971 at domone dot podge> <CAAHN_R2OzxGbDarALVD5rRJP6p7OZYh4di3MaTqcoRnLkaU8JQ at mail dot gmail dot com>
On Wed, Oct 23, 2013 at 08:15:37AM +0530, Siddhesh Poyarekar wrote:
> I have not done a full review of the patch, but I am of the opinion
> that if you can show that the generated code is identical, then such a
> cleanup patch should be OK. I'd like opinions from others from this
> though, so please wait for more reviews before you push this change.
>
> Siddhesh
I did clean compile with and without patch and
objdump -d test/libc.so > a
objdump -d test2/libc.so > b
diff a b
objdump -d test/math/libm.so > a
objdump -d test2/math/libm.so > b
diff a b
objdump -d test/nptl/libpthread.so > a
objdump -d test2/nptl/libpthread.so > b
diff a b
and binaries are identical.