This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Don't include tls.h in test cases


Hi,

Some test cases I was looking at included tls.h when it wasn't needed.
Following patch removes those includes.  Tested on x86_64 to verify
that this doesn't break the tests and generates identical code in the
test binaries and DSOs.  OK to commit?

Siddhesh

	* elf/tst-tls-dlinfo.c: Don't include tls.h.
	* elf/tst-tls1.c: Likewise.
	* elf/tst-tls10.h: Likewise.
	* elf/tst-tls14.c: Likewise.
	* elf/tst-tls2.c: Likewise.
	* elf/tst-tls3.c: Likewise.
	* elf/tst-tls4.c: Likewise.
	* elf/tst-tls5.c: Likewise.
	* elf/tst-tls6.c: Likewise.
	* elf/tst-tls7.c: Likewise.
	* elf/tst-tls8.c: Likewise.
	* elf/tst-tls9.c: Likewise.
	* elf/tst-tlsmod1.c: Likewise.
	* elf/tst-tlsmod13.c: Likewise.
	* elf/tst-tlsmod13a.c: Likewise.
	* elf/tst-tlsmod14a.c: Likewise.
	* elf/tst-tlsmod16a.c: Likewise.
	* elf/tst-tlsmod16b.c: Likewise.
	* elf/tst-tlsmod2.c: Likewise.
	* elf/tst-tlsmod3.c: Likewise.
	* elf/tst-tlsmod4.c: Likewise.
	* elf/tst-tlsmod5.c: Likewise.
	* elf/tst-tlsmod6.c: Likewise.

diff --git a/elf/tst-tls-dlinfo.c b/elf/tst-tls-dlinfo.c
index 26c2811..28661b1 100644
--- a/elf/tst-tls-dlinfo.c
+++ b/elf/tst-tls-dlinfo.c
@@ -2,8 +2,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 
-#include <tls.h>
-
 
 #define TEST_FUNCTION do_test ()
 static int
diff --git a/elf/tst-tls1.c b/elf/tst-tls1.c
index 3b9b10f..bec0a2f 100644
--- a/elf/tst-tls1.c
+++ b/elf/tst-tls1.c
@@ -1,8 +1,6 @@
 /* glibc test for TLS in ld.so.  */
 #include <stdio.h>
 
-#include <tls.h>
-
 #include "tls-macros.h"
 
 
diff --git a/elf/tst-tls10.h b/elf/tst-tls10.h
index 2b5709a..7c8c6a6 100644
--- a/elf/tst-tls10.h
+++ b/elf/tst-tls10.h
@@ -1,4 +1,3 @@
-#include <tls.h>
 #include <stdlib.h>
 
 struct A
diff --git a/elf/tst-tls14.c b/elf/tst-tls14.c
index ffd31e9..6bacb59 100644
--- a/elf/tst-tls14.c
+++ b/elf/tst-tls14.c
@@ -4,8 +4,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 
-#include <tls.h>
-
 #define AL 4096
 struct foo
 {
diff --git a/elf/tst-tls2.c b/elf/tst-tls2.c
index 3d13272..d0b6d51 100644
--- a/elf/tst-tls2.c
+++ b/elf/tst-tls2.c
@@ -1,8 +1,6 @@
 /* glibc test for TLS in ld.so.  */
 #include <stdio.h>
 
-#include <tls.h>
-
 #include "tls-macros.h"
 
 
diff --git a/elf/tst-tls3.c b/elf/tst-tls3.c
index c5e501e..ca96c6a 100644
--- a/elf/tst-tls3.c
+++ b/elf/tst-tls3.c
@@ -1,8 +1,6 @@
 /* glibc test for TLS in ld.so.  */
 #include <stdio.h>
 
-#include <tls.h>
-
 #include "tls-macros.h"
 
 
diff --git a/elf/tst-tls4.c b/elf/tst-tls4.c
index 4ae33db..63170c3 100644
--- a/elf/tst-tls4.c
+++ b/elf/tst-tls4.c
@@ -2,8 +2,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 
-#include <tls.h>
-
 
 #define TEST_FUNCTION do_test ()
 static int
diff --git a/elf/tst-tls5.c b/elf/tst-tls5.c
index 27b1829..76905c5 100644
--- a/elf/tst-tls5.c
+++ b/elf/tst-tls5.c
@@ -2,8 +2,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 
-#include <tls.h>
-
 
 #define TEST_FUNCTION do_test ()
 static int
diff --git a/elf/tst-tls6.c b/elf/tst-tls6.c
index 021622d..9e6235f 100644
--- a/elf/tst-tls6.c
+++ b/elf/tst-tls6.c
@@ -3,7 +3,6 @@
 #include <stdlib.h>
 
 #include <link.h>
-#include <tls.h>
 
 
 #define TEST_FUNCTION do_test ()
diff --git a/elf/tst-tls7.c b/elf/tst-tls7.c
index 1edc2b6..23a16e4 100644
--- a/elf/tst-tls7.c
+++ b/elf/tst-tls7.c
@@ -3,7 +3,6 @@
 #include <stdlib.h>
 
 #include <link.h>
-#include <tls.h>
 
 
 #define TEST_FUNCTION do_test ()
diff --git a/elf/tst-tls8.c b/elf/tst-tls8.c
index 36b1bac..4bf3e3f 100644
--- a/elf/tst-tls8.c
+++ b/elf/tst-tls8.c
@@ -3,7 +3,6 @@
 #include <stdlib.h>
 
 #include <link.h>
-#include <tls.h>
 
 
 #define TEST_FUNCTION do_test ()
diff --git a/elf/tst-tls9.c b/elf/tst-tls9.c
index 1207851..6306fb5 100644
--- a/elf/tst-tls9.c
+++ b/elf/tst-tls9.c
@@ -3,7 +3,6 @@
 #include <stdlib.h>
 
 #include <link.h>
-#include <tls.h>
 
 #define TEST_FUNCTION do_test ()
 static int
diff --git a/elf/tst-tlsmod1.c b/elf/tst-tlsmod1.c
index 4d966c9..8d91567 100644
--- a/elf/tst-tlsmod1.c
+++ b/elf/tst-tlsmod1.c
@@ -1,7 +1,5 @@
 #include <stdio.h>
 
-#include <tls.h>
-
 #include "tls-macros.h"
 
 
diff --git a/elf/tst-tlsmod13.c b/elf/tst-tlsmod13.c
index 76da630..7712d8b 100644
--- a/elf/tst-tlsmod13.c
+++ b/elf/tst-tlsmod13.c
@@ -1,5 +1,3 @@
-#include <tls.h>
-
 __thread int a[2] __attribute__ ((tls_model ("initial-exec")));
 
 int
diff --git a/elf/tst-tlsmod13a.c b/elf/tst-tlsmod13a.c
index d5515d4..ca4eacc 100644
--- a/elf/tst-tlsmod13a.c
+++ b/elf/tst-tlsmod13a.c
@@ -1,5 +1,3 @@
-#include <tls.h>
-
 __thread int b[2] __attribute__ ((tls_model ("initial-exec")));
 
 extern int foo (void);
diff --git a/elf/tst-tlsmod14a.c b/elf/tst-tlsmod14a.c
index 6806d34..824c06d 100644
--- a/elf/tst-tlsmod14a.c
+++ b/elf/tst-tlsmod14a.c
@@ -1,8 +1,6 @@
 #include <stdint.h>
 #include <stdio.h>
 
-#include <tls.h>
-
 #define AL 4096
 struct foo
 {
diff --git a/elf/tst-tlsmod16a.c b/elf/tst-tlsmod16a.c
index c16e603..4ec6a6c 100644
--- a/elf/tst-tlsmod16a.c
+++ b/elf/tst-tlsmod16a.c
@@ -1,3 +1 @@
-#include <tls.h>
-
 int __thread tlsvar;
diff --git a/elf/tst-tlsmod16b.c b/elf/tst-tlsmod16b.c
index 7268c56..1ecba26 100644
--- a/elf/tst-tlsmod16b.c
+++ b/elf/tst-tlsmod16b.c
@@ -1,5 +1,3 @@
-#include <tls.h>
-
 extern __thread int tlsvar __attribute__((tls_model("initial-exec")));
 
 void *
diff --git a/elf/tst-tlsmod2.c b/elf/tst-tlsmod2.c
index 9819233..40eb140 100644
--- a/elf/tst-tlsmod2.c
+++ b/elf/tst-tlsmod2.c
@@ -1,7 +1,5 @@
 #include <stdio.h>
 
-#include <tls.h>
-
 #include "tls-macros.h"
 
 
diff --git a/elf/tst-tlsmod3.c b/elf/tst-tlsmod3.c
index 5c456ee..6d186c4 100644
--- a/elf/tst-tlsmod3.c
+++ b/elf/tst-tlsmod3.c
@@ -1,7 +1,5 @@
 #include <stdio.h>
 
-#include <tls.h>
-
 #include "tls-macros.h"
 
 extern int in_dso (int n, int *caller_foop);
diff --git a/elf/tst-tlsmod4.c b/elf/tst-tlsmod4.c
index dd95486..86889aa 100644
--- a/elf/tst-tlsmod4.c
+++ b/elf/tst-tlsmod4.c
@@ -1,7 +1,5 @@
 #include <stdio.h>
 
-#include <tls.h>
-
 #include "tls-macros.h"
 
 
diff --git a/elf/tst-tlsmod5.c b/elf/tst-tlsmod5.c
index 00d3a9d..a97c7e5 100644
--- a/elf/tst-tlsmod5.c
+++ b/elf/tst-tlsmod5.c
@@ -1,5 +1,3 @@
-#include <tls.h>
-
 #include "tls-macros.h"
 
 COMMON_INT_DEF(foo);
diff --git a/elf/tst-tlsmod6.c b/elf/tst-tlsmod6.c
index 244d9ae..e968596 100644
--- a/elf/tst-tlsmod6.c
+++ b/elf/tst-tlsmod6.c
@@ -1,5 +1,3 @@
-#include <tls.h>
-
 #include "tls-macros.h"
 
 COMMON_INT_DEF(bar);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]