This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [ping2][PATCH v2] Add systemtap markers to math function slow paths
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>, <law at redhat dot com>, <carlos at redhat dot com>
- Date: Mon, 14 Oct 2013 23:54:17 +0000
- Subject: Re: [ping2][PATCH v2] Add systemtap markers to math function slow paths
- Authentication-results: sourceware.org; auth=none
- References: <20130911053106 dot GH4306 at spoyarek dot pnq dot redhat dot com> <20130911053427 dot GI4306 at spoyarek dot pnq dot redhat dot com> <20130917061817 dot GF13304 at spoyarek dot pnq dot redhat dot com> <20131004055126 dot GC28855 at spoyarek dot pnq dot redhat dot com> <20131011112644 dot GI3178 at spoyarek dot pnq dot redhat dot com>
I see warnings, building for a non-systemtap configuration, of the form:
../sysdeps/ieee754/dbl-64/e_atan2.c:602:4: warning: the address of 'p' will always evaluate as 'true' [-Waddress]
It looks like the bool array used for the dummy probe macro
implementations will need to change if probes involve addresses of
non-weak variables (which generate this warning when converted to bool).
I expect that initializers of the form ((void) arg, 0) would be suitable
(although you won't just be able to use __VA_ARGS__ then to evaluate all
the probe arguments but would need LIBC_PROBE to map to separate macros
for each number of arguments).
--
Joseph S. Myers
joseph@codesourcery.com