This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #13724] Do not segfault in pthread_setname_np (x, NULL)
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Rich Felker <dalias at aerifal dot cx>, Carlos O'Donell <carlos at redhat dot com>, libc-alpha at sourceware dot org
- Date: Mon, 7 Oct 2013 16:59:32 +0200
- Subject: Re: [PATCH][BZ #13724] Do not segfault in pthread_setname_np (x, NULL)
- Authentication-results: sourceware.org; auth=none
- References: <20131003122009 dot GA8891 at domone dot podge> <524DCA52 dot 2030609 at redhat dot com> <20131007141928 dot GV20515 at brightrain dot aerifal dot cx> <mvmli25xhm3 dot fsf at hawking dot suse dot de> <20131007145009 dot GX20515 at brightrain dot aerifal dot cx> <mvmhactxhc3 dot fsf at hawking dot suse dot de>
On Mon, Oct 07, 2013 at 04:53:48PM +0200, Andreas Schwab wrote:
> Rich Felker <dalias@aerifal.cx> writes:
>
> > You disagree with my opinion
>
> No, I agree to disagree.
>
> Andreas.
>
Then do you agree with crashing at pthread_getname_np and waitpid?
diff --git a/nptl/sysdeps/unix/sysv/linux/pthread_getname.c b/nptl/sysdeps/unix/sysv/linux/pthread_getname.c
index f5dc336..e0582fa 100644
--- a/nptl/sysdeps/unix/sysv/linux/pthread_getname.c
+++ b/nptl/sysdeps/unix/sysv/linux/pthread_getname.c
@@ -41,6 +41,10 @@ pthread_getname_np (th, buf, len)
if (len < TASK_COMM_LEN)
return ERANGE;
+ /* Crash when null buffer is supplied. */
+ if (len)
+ buf[0] = '\0';
+
if (pd == THREAD_SELF)
return prctl (PR_GET_NAME, buf) ? errno : 0;