This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Async signal safe TLS accesses
- From: Andrew Hunter <ahh at google dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>, "Carlos O'Donell" <carlos at redhat dot com>, Ian Lance Taylor <iant at google dot com>, Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: Andrew Hunter <ahh at google dot com>
- Date: Thu, 3 Oct 2013 13:08:47 -0700
- Subject: Re: [PATCH] Async signal safe TLS accesses
- Authentication-results: sourceware.org; auth=none
- References: <1379977289-21260-1-git-send-email-ahh at google dot com> <1380830518-16721-1-git-send-email-ahh at google dot com>
On Thu, Oct 3, 2013 at 1:01 PM, Andrew Hunter <ahh@google.com> wrote:
>
This is v2 of the patch. Symbols are not exported; the API is named
__signal_safe_X, a few typos fixed.
I added a test case to nptl/ that accesses TLS (first) from signal
handlers. It passes with this patch (and merrily deadlocks without
it.)
FYI, at HEAD (before my patch), a few tests fail on my system, but
this patch does not cause any new failures. For the record, the tests
I had to disable:
elf/ifuncmain1staticpie
elf/ifuncmain6pie
elf/ifuncmain7pie
localedata/bug-iconv-trans
localedata/tst_mblen
localedata/tst_mbrlen
localedata/tst_mbrtowc
localedata/tst_mbsrtowcs
localedata/tst_mbstowcs
localedata/tst_mbtowc
localedata/tst_swscanf
localedata/tst_wcrtomb
localedata/tst_wcsrtombs
localedata/tst_wcstombs
localedata/tst_wctob
localedata/tst_wctomb
localedata/tst_wctype
Does anyone have any remaining concerns with this patch that haven't
been covered yet?