This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Properly cache the result from looking up the nss database config


On Thu, Jan 24, 2013 at 12:46:27PM +0100, Andreas Schwab wrote:
> The last argument of __nss_database_lookup is supposed to be used as a
> cache for the lookup result, but three callers do not properly make use
> of it: they store it in a local variable instead of in the static one
> that is defined for that purpose.  __nss_database_lookup is expecting to
> be called only once for each database; if there is no config for a
> database it reparses the default each time which allocates new memory
> (though technically it's not a leak since it frees all of it at program
> exit).
> 
> Andreas.
>

As discussed in
http://sourceware.org/ml/libc-alpha/2013-09/msg00735.html
there is another patch that fixes same bug.

As this fixes logic in more places than alternative I would go with this
patch.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]