This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Consistently use page_shift in sysdeps/unix/sysv/linux/mmap64.c
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, <libc-alpha at sourceware dot org>
- Date: Fri, 20 Sep 2013 21:32:28 +0200
- Subject: Re: Consistently use page_shift in sysdeps/unix/sysv/linux/mmap64.c
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1306282000050 dot 15167 at digraph dot polyomino dot org dot uk> <20130628213457 dot 38E962C09C at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1307012238110 dot 13535 at digraph dot polyomino dot org dot uk> <20130709195358 dot 138252C078 at topped-with-meat dot com>
* include/string.h (__ffs): Declare as hidden.
* string/ffs.c (__ffs): Define as hidden.
* sysdeps/i386/ffs.c (__ffs): Likewise.
* sysdeps/i386/i686/ffs.c (__ffs): Likewise.
* sysdeps/powerpc/ffs.c (__ffs): Likewise.
* sysdeps/s390/ffs.c (__ffs): Likewise.
* sysdeps/x86_64/ffs.c (__ffs): Likewise.
* sysdeps/alpha/alphaev67/ffs.S (__ffs): Define as hidden.
* sysdeps/alpha/ffs.S (__ffs): Likewise.
* sysdeps/arm/armv6t2/ffs.S (__ffs): Define as hidden.
* sysdeps/m68k/ffs.c (__ffs): Define as hidden.
* sysdeps/tile/ffs.c (__ffs): Define as hidden.
diff --git a/include/string.h b/include/string.h
index d6d8594..8323412 100644
--- a/include/string.h
+++ b/include/string.h
@@ -90,6 +90,7 @@ extern char *__strsep_g (char **__stringp, const char *__delim);
libc_hidden_proto (__strsep_g)
libc_hidden_proto (strnlen)
libc_hidden_proto (memmem)
+libc_hidden_proto (__ffs)
libc_hidden_builtin_proto (memchr)
libc_hidden_builtin_proto (memcpy)
diff --git a/ports/sysdeps/alpha/alphaev67/ffs.S b/ports/sysdeps/alpha/alphaev67/ffs.S
index e453152..9b3463c 100644
--- a/ports/sysdeps/alpha/alphaev67/ffs.S
+++ b/ports/sysdeps/alpha/alphaev67/ffs.S
@@ -47,4 +47,5 @@ ENTRY(__ffs)
END(__ffs)
weak_alias (__ffs, ffs)
+libc_hidden_def (__ffs)
libc_hidden_builtin_def (ffs)
diff --git a/ports/sysdeps/alpha/ffs.S b/ports/sysdeps/alpha/ffs.S
index def0f25..d1f0c83 100644
--- a/ports/sysdeps/alpha/ffs.S
+++ b/ports/sysdeps/alpha/ffs.S
@@ -85,6 +85,7 @@ $ffsl..ng:
END(ffsl)
weak_alias (__ffs, ffs)
+libc_hidden_def (__ffs)
libc_hidden_builtin_def (ffs)
weak_extern (ffsl)
weak_alias (ffsl, ffsll)
diff --git a/ports/sysdeps/arm/armv6t2/ffs.S b/ports/sysdeps/arm/armv6t2/ffs.S
index b2c88b9..9f99930 100644
--- a/ports/sysdeps/arm/armv6t2/ffs.S
+++ b/ports/sysdeps/arm/armv6t2/ffs.S
@@ -32,4 +32,5 @@ END (__ffs)
weak_alias (__ffs, ffs)
weak_alias (__ffs, ffsl)
+libc_hidden_def (__ffs)
libc_hidden_builtin_def (ffs)
diff --git a/ports/sysdeps/m68k/ffs.c b/ports/sysdeps/m68k/ffs.c
index fd4e5ff..a3c1a0d 100644
--- a/ports/sysdeps/m68k/ffs.c
+++ b/ports/sysdeps/m68k/ffs.c
@@ -36,6 +36,7 @@ __ffs (x)
return 32 - cnt;
}
weak_alias (__ffs, ffs)
+libc_hidden_def (__ffs)
libc_hidden_builtin_def (ffs)
#undef ffsl
weak_alias (__ffs, ffsl)
diff --git a/ports/sysdeps/tile/ffs.c b/ports/sysdeps/tile/ffs.c
index 93ad980..eb982a6 100644
--- a/ports/sysdeps/tile/ffs.c
+++ b/ports/sysdeps/tile/ffs.c
@@ -27,6 +27,7 @@ __ffs (int x)
return __builtin_ffs (x);
}
weak_alias (__ffs, ffs)
+libc_hidden_def (__ffs)
libc_hidden_builtin_def (ffs)
#undef ffsll
diff --git a/string/ffs.c b/string/ffs.c
index a645224..916c5c3 100644
--- a/string/ffs.c
+++ b/string/ffs.c
@@ -46,6 +46,7 @@ __ffs (i)
return table[x >> a] + a;
}
weak_alias (__ffs, ffs)
+libc_hidden_def (__ffs)
libc_hidden_builtin_def (ffs)
#if ULONG_MAX == UINT_MAX
diff --git a/sysdeps/i386/ffs.c b/sysdeps/i386/ffs.c
index 47496dc..77d2e60 100644
--- a/sysdeps/i386/ffs.c
+++ b/sysdeps/i386/ffs.c
@@ -41,6 +41,7 @@ __ffs (x)
return cnt;
}
weak_alias (__ffs, ffs)
+libc_hidden_def (__ffs)
libc_hidden_builtin_def (ffs)
#undef ffsl
weak_alias (__ffs, ffsl)
diff --git a/sysdeps/i386/i686/ffs.c b/sysdeps/i386/i686/ffs.c
index 5c97050..cde1c99 100644
--- a/sysdeps/i386/i686/ffs.c
+++ b/sysdeps/i386/i686/ffs.c
@@ -39,6 +39,7 @@ __ffs (x)
return cnt + 1;
}
weak_alias (__ffs, ffs)
+libc_hidden_def (__ffs)
libc_hidden_builtin_def (ffs)
#undef ffsl
weak_alias (__ffs, ffsl)
diff --git a/sysdeps/powerpc/ffs.c b/sysdeps/powerpc/ffs.c
index e0fee46..deba0cd 100644
--- a/sysdeps/powerpc/ffs.c
+++ b/sysdeps/powerpc/ffs.c
@@ -35,6 +35,7 @@ __ffs (int x)
return 32 - cnt;
}
weak_alias (__ffs, ffs)
+libc_hidden_def (__ffs)
libc_hidden_builtin_def (ffs)
#if ULONG_MAX == UINT_MAX
#undef ffsl
diff --git a/sysdeps/s390/ffs.c b/sysdeps/s390/ffs.c
index 807441d..2dbb743 100644
--- a/sysdeps/s390/ffs.c
+++ b/sysdeps/s390/ffs.c
@@ -63,6 +63,7 @@ __ffs (x)
}
weak_alias (__ffs, ffs)
+libc_hidden_def (__ffs)
libc_hidden_builtin_def (ffs)
#if ULONG_MAX == UINT_MAX
#undef ffsl
diff --git a/sysdeps/x86_64/ffs.c b/sysdeps/x86_64/ffs.c
index 27013d6..07ee7dd 100644
--- a/sysdeps/x86_64/ffs.c
+++ b/sysdeps/x86_64/ffs.c
@@ -35,4 +35,5 @@ __ffs (int x)
return cnt + 1;
}
weak_alias (__ffs, ffs)
+libc_hidden_def (__ffs)
libc_hidden_builtin_def (ffs)
--
1.8.4
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."