This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ping][BZ #15963, 15608, 15609, 15610, 15681] New language codes and locales


On 09/20/2013 01:11 AM, Carlos O'Donell wrote:
> On 09/20/2013 12:45 AM, Chris Leonard wrote:
>> Committed with suggested changes.
>>
>> I was able to close the tickets myself.
> 
> The changes look good.
> 
> Three nits to fixup next time you commit.

Make that four nits.

Changes to NEWS, other than simply adding a fixed BZ#,
should get reviewed. They should be complete sentences
and something that an end-user would understand.

Just to give you an example I'm going to checkin the
following copy-edit to your NEWS entries.

diff --git a/NEWS b/NEWS
index 690e1cb..07af4fd 100644
--- a/NEWS
+++ b/NEWS
@@ -25,15 +25,16 @@ Version 2.19
 
 * New locales: quz_PE.
 
-* Add country_car field to LC_ADDRESS, many locales.
+* The LC_ADDRESS field was updated to support country_car for almost all
+  supported locales.
 
-* Update iso-1427.def and related occurrences.
+* ISO 1427 definitions were updated.
 
 * The configure option --disable-versioning has been removed.  Builds with
   --disable-versioning had not worked for several years.
 
-* Update iso-639.def with Chiga (cgg) and Chinese (gan, hak, czh, cjy, lzh,
-  cmn, mnp, cdo, czo, cpx, wuu, hsn, yue).
+* ISO 639 definitions were updated for Chiga (cgg) and Chinese (gan, hak, czh,
+  cjy, lzh, cmn, mnp, cdo, czo, cpx, wuu, hsn, yue).
 
 ^L
 Version 2.18
---

We make it immediately obvious what it is
that's important. In the case of the ISO definition
file updates we lead with "ISO XXX definitions were 
updated ...".

In the case of the country_car additions, what's important
is that LC_ADDRESS now has support for them in almost all
locales.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]