This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] MIPS: IEEE 754-2008 NaN encoding support
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <libc-ports at sourceware dot org>, <libc-alpha at sourceware dot org>, Thomas Schwinge <thomas at codesourcery dot com>, Doug Gilmore <Doug dot Gilmore at imgtec dot com>
- Date: Wed, 18 Sep 2013 21:48:10 +0100
- Subject: Re: [PATCH v3] MIPS: IEEE 754-2008 NaN encoding support
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1308222343480 dot 8514 at tp dot orcam dot me dot uk> <Pine dot LNX dot 4 dot 64 dot 1308231511370 dot 22185 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 1 dot 10 dot 1309032201260 dot 29360 at tp dot orcam dot me dot uk> <Pine dot LNX dot 4 dot 64 dot 1309061622410 dot 8532 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 1 dot 10 dot 1309101029530 dot 29360 at tp dot orcam dot me dot uk> <Pine dot LNX dot 4 dot 64 dot 1309102319460 dot 18202 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 1 dot 10 dot 1309131701410 dot 29360 at tp dot orcam dot me dot uk> <Pine dot LNX dot 4 dot 64 dot 1309161524580 dot 22677 at digraph dot polyomino dot org dot uk>
On Mon, 16 Sep 2013, Joseph S. Myers wrote:
> > Thanks. Here's a small update including a change made by Thomas that I
> > missed in the original submission (sorry):
> >
> > * sysdeps/mips/math_private.h [__mips_nan2008]
> > (HIGH_ORDER_BIT_IS_SET_FOR_SNAN): Don't define.
> > * sysdeps/mips/bits/nan.h [__mips_nan2008] (NAN, __qnan_bytes):
> > Define appropriately.
> >
> > I hope that these changes are OK. No regressions in o32/n64/n32 testing.
> >
> > OK for this version?
>
> OK, though the bits/nan.h change in the case for pre-3.3 GCC is redundant
> since no such GCC will define __mips_nan2008.
I've been pondering about that part, in particular whether as an
alternative we'd need a #error directive to catch the unsupported
__mips_nan2008/pre-3.3-GCC case. Eventually I decided to propose it as
is, as it is technically correct, however without any explicit mention of
it so as not to suggest anything. Now that you've questioned it by
yourself, I have replaced that hunk altogether with a informational note:
/* No 2008-NaN mode support in any GCC version before 4.9. */
I have applied this change now, with this adjustment made. Thanks for
your review.
Maciej