This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH,RFA] Ensure check_may_shrink_heap always returns the final value
- From: Andreas Schwab <schwab at suse dot de>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 18 Sep 2013 09:11:51 +0200
- Subject: Re: [PATCH,RFA] Ensure check_may_shrink_heap always returns the final value
- Authentication-results: sourceware.org; auth=none
- References: <or1u4n5aig dot fsf at livre dot home>
Alexandre Oliva <aoliva@redhat.com> writes:
> diff --git a/sysdeps/unix/sysv/linux/malloc-sysdep.h b/sysdeps/unix/sysv/linux/malloc-sysdep.h
> index 737ca0e..346c93c 100644
> --- a/sysdeps/unix/sysv/linux/malloc-sysdep.h
> +++ b/sysdeps/unix/sysv/linux/malloc-sysdep.h
> @@ -33,7 +33,8 @@
> static inline bool
> check_may_shrink_heap (void)
> {
> - static int may_shrink_heap = -1;
> + static int global_may_shrink_heap = -1;
> + int may_shrink_heap = global_may_shrink_heap;
I don't think this will suffice, the compiler may still fall back to
reload the value from the static. You can use force_reg to disassociate
the two variables.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."