This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix bug 15915, erroneous make rule for linkobj/libc.so.
- From: Brooks Moses <bmoses at google dot com>
- To: Roland McGrath <roland at hack dot frob dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Tue, 17 Sep 2013 10:33:20 -0700
- Subject: Re: [patch] Fix bug 15915, erroneous make rule for linkobj/libc.so.
- Authentication-results: sourceware.org; auth=none
- References: <CAOxa4KomMpMcTRhCQtT9cWNeZ7QbzxBwQNbTL=qvCcLjk1L6fQ at mail dot gmail dot com> <CAOxa4KpUcQOmKadisHmVTX-nxon-0uhoyGhDT-2U+Zx01va40Q at mail dot gmail dot com> <CAAKybw9ttZJG1MYwKeh-ap24yBQVHiYXz4wrQ-_xGm3x+2D7=w at mail dot gmail dot com> <CAOxa4KrBhdzNP9uzba=-hguu69VXZ2XwZunRiURgk2hrp7Duqg at mail dot gmail dot com> <1378744628 dot 5770 dot 349 dot camel at ubuntu-sellcey> <CAOxa4KpK2z5OrGG0XNLdMEtYXfpZChoBhHChgCmD0YuCbkQBgQ at mail dot gmail dot com> <1378757027 dot 5770 dot 352 dot camel at ubuntu-sellcey> <CAOxa4Kq=+157Do-KEgO16Kmf7iYfnNzqDELeJpPdoSFU1oDEmA at mail dot gmail dot com>
Ping?
Roland, as per Ryan's request, I'm waiting on an Ack from you before committing.
On Mon, Sep 9, 2013 at 1:38 PM, Brooks Moses <bmoses@google.com> wrote:
> Steve,
>
> On Mon, Sep 9, 2013 at 1:03 PM, Steve Ellcey <sellcey@mips.com> wrote:
>> I think there are still some tab/space problems with this patch. It
>> applied cleanly but when I built I got:
>
> Crud; I'm sorry. I guess this is what I get from cut-and-pasting
> things from a diff file (trying to get a revised patch out from my
> laptop this weekend so you wouldn't have to wait) rather than waiting
> until I could update my tree and test things properly.
>
> The attached patch is now properly tested (on a native build): It goes
> through a "configure --prefix=...; make -j24" cycle successfully, and
> the installed trees with and without the patch differ only in lib/*.a
> files, and those are exactly the same sizes implying that the
> differences are just timestamps.
>
> Roland, is this one ok to commit?
>
> - Brooks