This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH V3] sunrpc/rpc/types.h: Fix OS X and FreeBSD build problem.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: Jia Liu <proljc at gmail dot com>, libc-alpha at sourceware dot org
- Date: Thu, 12 Sep 2013 09:09:38 -0400
- Subject: Re: [PATCH V3] sunrpc/rpc/types.h: Fix OS X and FreeBSD build problem.
- Authentication-results: sourceware.org; auth=none
- References: <1378483268-32800-1-git-send-email-proljc at gmail dot com> <201309061643 dot 24498 dot vapier at gentoo dot org> <522A8EED dot 9000905 at redhat dot com> <201309111829 dot 33019 dot vapier at gentoo dot org>
On 09/11/2013 06:29 PM, Mike Frysinger wrote:
> On Friday 06 September 2013 22:26:53 Carlos O'Donell wrote:
>> On 09/06/2013 04:43 PM, Mike Frysinger wrote:
>>> Acked-by: Mike Frysinger <vapier@gentoo.org>
>>
>> Given that you reviewed this patch would you mind
>> checking it in? I think there is consensus that
>> the minimal v3 change is useful. Could you also
>> fixup the ChangeLog?
>
> i was hoping someone else would review and chip in yeah/nay. but i'll
> merge it now.
It looked fine to me, was restricted to two other OSs,
and didn't make anything worse IMO.
You became de-facto lead reviewer by opening your mouth
first, but if you want more review that's your perogative
and you can ask for it :-)
Cheers,
Carlos.