This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][BZ #832][BZ #3266] Make ldd try_trace more robust and portable
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: "Patrick 'P. J.' McDermott" <pj+sourceware-ml at pehjota dot net>, <libc-alpha at sourceware dot org>
- Date: Wed, 11 Sep 2013 21:38:25 +0000
- Subject: Re: [PATCH v2][BZ #832][BZ #3266] Make ldd try_trace more robust and portable
- Authentication-results: sourceware.org; auth=none
- References: <522B4A29 dot 3060509 at pehjota dot net> <201309101704 dot 16679 dot vapier at gentoo dot org> <5230CDD3 dot 4070108 at pehjota dot net> <201309111707 dot 54978 dot vapier at gentoo dot org>
On Wed, 11 Sep 2013, Mike Frysinger wrote:
> > I assume you mean that whoever commits this change (with corrections
> > I'll be posting soon) should add the bug numbers to NEWS? Or should I
> > propose a new entry for NEWS documenting this change?
>
> include in your patch the changes needed for NEWS. at the top of it, you'll
> find a list of bug numbers you should update.
Patch submissions should not include a diff to that list, just as the
ChangeLog entries should not be included as diffs either: such diffs never
apply cleanly. It's for the committer to insert the ChangeLog entries at
the start of the ChangeLog files and edit the list of fixed bugs in NEWS
in the obvious way.
Now, hopefully the outcome of this patch series will be that at least ldd,
maybe other installed scripts as well, becomes an sh script rather than a
bash script, no longer needing "#! @BASH@" to force bash usage and usable
on systems without bash. *That* would merit its own NEWS entry, separate
from the list of fixed bug numbers, which might reasonably be included in
the submitted diffs. But it also needs other fixes in this series, for
$"" usage, so inclusion with this particular patch would be premature.
--
Joseph S. Myers
joseph@codesourcery.com