This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Fix static-binary lazy FPU context allocation
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 06 Sep 2013 17:22:01 -0400
- Subject: Re: [PATCH v2] Fix static-binary lazy FPU context allocation
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1308221904520 dot 8514 at tp dot orcam dot me dot uk> <52260408 dot 2030809 at redhat dot com> <alpine dot DEB dot 1 dot 10 dot 1309042303200 dot 29360 at tp dot orcam dot me dot uk> <52297584 dot 3030205 at redhat dot com> <alpine dot DEB dot 1 dot 10 dot 1309062204490 dot 29360 at tp dot orcam dot me dot uk>
On 09/06/2013 05:14 PM, Maciej W. Rozycki wrote:
>>> 2013-09-05 Maciej W. Rozycki <macro@codesourcery.com>
>>>
>>> * csu/init-first.c (_init): Remove the !SHARED condition around
>>> FPU control word initialization.
>>> * elf/dl-support.c (_dl_fpu_control): New variable.
>>> (_dl_aux_init) <AT_FPUCW>: Initialize it.
>>> * math/test-fpucw.c [!FPU_CONTROL] (FPU_CONTROL): New macro.
>>> (main): Replace _FPU_DEFAULT with FPU_CONTROL throughout.
>>> * math/test-fpucw-static.c: New file.
>>> * math/test-fpucw-ieee.c: New file.
>>> * math/test-fpucw-ieee-static.c: New file.
>>> * math/Makefile (tests): Add `test-fpucw-ieee' and
>>> `$(tests-static)'.
>>> (tests-static): New variable.
>>> [($(build-shared),yes)] ($(addprefix $(objpfx),$(tests))): Move
>>> dependency to...
>>> [($(build-shared),yes)]
>>> ($(addprefix $(objpfx),$(filter-out $(tests-static),$(tests)))):
>>> ... this.
>>> [($(build-shared),yes)] ($(addprefix $(objpfx),$(tests-static))):
>>> New dependency.
>>
>> I'm happy with this, thanks for adding the extra static tests
>> and the comment.
>
> Thank you for your review.
>
> Does anyone else has anything to add, any comments or objections perhaps?
> Have we reached consensus?
I don't see anyone opposed to your change. There have been several
comments about how this needs to be cleaned up, and that's exactly
what your patch is doing. Ryan and I have looked at it and I think
that's consensus enough to commit the changes to master. Joseph
commented on it and didn't object which is a strong vote of confidence.
I would check it in immediately, but if you wish to be conservative
wait until Monday and allow others to catch up on their email over
the weekend.
Cheers,
Carlos.