This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix bug 15915, erroneous make rule for linkobj/libc.so.


On Fri, Sep 6, 2013 at 1:59 PM, Brooks Moses <bmoses@google.com> wrote:
> Ping?
>
> As per https://sourceware.org/ml/libc-ports/2013-09/msg00061.html,
> looks like other people are running into the relevant build-breakage
> as well.
>
>
> On Fri, Aug 30, 2013 at 8:26 PM, Brooks Moses <bmoses@google.com> wrote:
>> As described in bug 15915, the pattern rule for lib%.so files in
>> Makerules includes linkobj/libc.so as a dependency.  However, the
>> explicit rule for linkobj/libc.so is in the top-level Makefile.
>>
>> Thus, the subdirectory makefiles that include Makerules end up with an
>> erroneous makefile pattern rule for linkobj/libc.so that includes
>> itself as a dependency.  The result is make warnings whenever rules
>> for other .so files are resolved -- and, on occasion, actual makefile
>> failures when a race condition causes the implicit rule to actually be
>> used.
>>
>> This patch moves the explicit rules for linkobj/libc.so into Makerules
>> to clear up this problem.  It also elaborates a couple of comments
>> that I'd initially found confusing.
>>
>> I've confirmed that this removes the circular-dependency warnings, and
>> that the build still completes correctly.
>>
>> Ok for trunk?
>>

I think this one should probably be Acked by Roland.

Ryan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]