This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix bug 15915, erroneous make rule for linkobj/libc.so.
- From: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- To: Brooks Moses <bmoses at google dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Roland McGrath <roland at hack dot frob dot com>
- Date: Fri, 6 Sep 2013 15:13:25 -0500
- Subject: Re: [patch] Fix bug 15915, erroneous make rule for linkobj/libc.so.
- Authentication-results: sourceware.org; auth=none
- References: <CAOxa4KomMpMcTRhCQtT9cWNeZ7QbzxBwQNbTL=qvCcLjk1L6fQ at mail dot gmail dot com> <CAOxa4KpUcQOmKadisHmVTX-nxon-0uhoyGhDT-2U+Zx01va40Q at mail dot gmail dot com>
On Fri, Sep 6, 2013 at 1:59 PM, Brooks Moses <bmoses@google.com> wrote:
> Ping?
>
> As per https://sourceware.org/ml/libc-ports/2013-09/msg00061.html,
> looks like other people are running into the relevant build-breakage
> as well.
>
>
> On Fri, Aug 30, 2013 at 8:26 PM, Brooks Moses <bmoses@google.com> wrote:
>> As described in bug 15915, the pattern rule for lib%.so files in
>> Makerules includes linkobj/libc.so as a dependency. However, the
>> explicit rule for linkobj/libc.so is in the top-level Makefile.
>>
>> Thus, the subdirectory makefiles that include Makerules end up with an
>> erroneous makefile pattern rule for linkobj/libc.so that includes
>> itself as a dependency. The result is make warnings whenever rules
>> for other .so files are resolved -- and, on occasion, actual makefile
>> failures when a race condition causes the implicit rule to actually be
>> used.
>>
>> This patch moves the explicit rules for linkobj/libc.so into Makerules
>> to clear up this problem. It also elaborates a couple of comments
>> that I'd initially found confusing.
>>
>> I've confirmed that this removes the circular-dependency warnings, and
>> that the build still completes correctly.
>>
>> Ok for trunk?
>>
I think this one should probably be Acked by Roland.
Ryan