This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Deduplicate copy benchtests.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- Cc: Will Newton <will dot newton at linaro dot org>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 6 Sep 2013 10:17:53 +0200
- Subject: Re: [PATCH] Deduplicate copy benchtests.
- Authentication-results: sourceware.org; auth=none
- References: <20130905163901 dot GA19182 at domone dot kolej dot mff dot cuni dot cz> <CANu=DmibZLSnZyS0ykO5vhwSGFh4ziSOk0opnr-wEhyLFJJxAQ at mail dot gmail dot com> <CAAHN_R0sJKS2AZjWsb_S1Zc0-rTNn+9DFLJWqO2qvfGcFjh46g at mail dot gmail dot com>
On Fri, Sep 06, 2013 at 09:33:22AM +0530, Siddhesh Poyarekar wrote:
> On 5 September 2013 22:29, Will Newton <will.newton@linaro.org> wrote:
> >> I added address randomization for copy implementations.
> >
> > This would be easier to review if it was a series of patches, e.g. one
> > doing the consolidation, one doing the removal of the tests, one doing
> > the addition of randomization.
>
> I agree. Please separate out changes that are logically distinct. It
> makes them easy to cherry pick too.
>
That can be done in next consolidations as its easier to use one
implementation and modify it bit than to rewrite implmenentations. They
will follow shortly.