This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Deduplicate copy benchtests.


On 5 September 2013 17:39, OndÅej BÃlka <neleai@seznam.cz> wrote:
> Hi,
>
> Benchtests now are difficult to change given number of places that need
> to be changed. This can be simplified by reducing duplicated code.
>
> Here I moved *cpy and memmove functions to common bench-copy.h file that
> is easier to update.
>
> I added address randomization for copy implementations.

This would be easier to review if it was a series of patches, e.g. one
doing the consolidation, one doing the removal of the tests, one doing
the addition of randomization.

-- 
Will Newton
Toolchain Working Group, Linaro


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]