This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [COMMITTED] [RFC] Add country_car field to LC_ADDRESS
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Chris Leonard <cjlhomeaddress at gmail dot com>
- Cc: Andreas Jaeger <aj at suse dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 4 Sep 2013 17:26:52 +0000
- Subject: Re: [COMMITTED] [RFC] Add country_car field to LC_ADDRESS
- Authentication-results: sourceware.org; auth=none
- References: <CAHdAatbAXRML0JufK20waK3kEhd_efnYFxZTSapjr0f79AboGA at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1309041449430 dot 9903 at digraph dot polyomino dot org dot uk> <CAHdAatb013XWQvyJNjTrvR-vZtAo+F_JdgemPvk9csWX36bQrQ at mail dot gmail dot com>
Also note: you appear to have a stray comma in your email address in some
ChangeLog entries. The [BZ #N] line should be indented by one tab, not
five spaces. There should not be a blank line at the top of ChangeLog.
And it's usual to rebase when merging your changes with other commits that
have been made to master since you made them, so merge commits themselves
are rarely seen in the history.
--
Joseph S. Myers
joseph@codesourcery.com