This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] benchtests/Makefile: Use LDLIBS instead of LDFLAGS.
- From: Will Newton <will dot newton at linaro dot org>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Patch Tracking <patches at linaro dot org>
- Date: Wed, 4 Sep 2013 15:44:34 +0100
- Subject: Re: [PATCH] benchtests/Makefile: Use LDLIBS instead of LDFLAGS.
- Authentication-results: sourceware.org; auth=none
- References: <52249EAA dot 80209 at linaro dot org> <20130902143749 dot GJ3273 at spoyarek dot pnq dot redhat dot com> <CANu=DmgLbgcarjJv3CF8RYGjPmXVb9QNTa8FQbs2C7QPM_1K0g at mail dot gmail dot com> <20130903164722 dot GC13895 at spoyarek dot pnq dot redhat dot com>
On 3 September 2013 17:47, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> On Tue, Sep 03, 2013 at 05:43:06PM +0100, Will Newton wrote:
>> On 2 September 2013 15:37, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
>> > On Mon, Sep 02, 2013 at 03:20:26PM +0100, Will Newton wrote:
>> >>
>> >> LDFLAGS puts the library too early in the command line if --as-needed
>> >> is being used. Use LDLIBS instead.
>> >>
>> >> ChangeLog:
>> >>
>> >> 2013-09-02 Will Newton <will.newton@linaro.org>
>> >>
>> >> * benchtests/Makefile: Use LDLIBS instead of LDFLAGS.
>> >> ---
>> >> benchtests/Makefile | 32 ++++++++++++++++----------------
>> >> 1 file changed, 16 insertions(+), 16 deletions(-)
>> >
>> > Looks good to me.
>>
>> Is it ok to go ahead and commit?
>
> Yes, unless you would like additional review.
Thanks, applied.
--
Will Newton
Toolchain Working Group, Linaro