This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2 v1.1][BZ #14547] Fix CVE-2012-4412
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Ondřej Bílka <neleai at seznam dot cz>
- Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, Andreas Schwab <schwab at suse dot de>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 21 Aug 2013 23:41:34 +0530
- Subject: Re: [PATCH 2/2 v1.1][BZ #14547] Fix CVE-2012-4412
- References: <20130630164500 dot GF2654 at spoyarek dot pnq dot redhat dot com> <mvmehagsfhm dot fsf at hawking dot suse dot de> <20130821151403 dot GB15273 at spoyarek dot pnq dot redhat dot com> <20130821160808 dot GA4369 at domone dot kolej dot mff dot cuni dot cz>
On 21 August 2013 21:38, Ondřej Bílka <neleai@seznam.cz> wrote:
> Is that goto needed? I would add conditions to if like following:
>
> if (!MIN (s1len, s2len) > size_max
> && !MAX (s1len, s2len) > size_max - MIN (s1len, s2len)
> && !__libc_use_alloca ((s1len + s2len) * (sizeof (int32_t) + 1)))
>
> There I assume that if below is single block, otherwise I would add new block.
It eliminates nesting and makes code easier to read. Not all goto is evil.
Siddhesh
--
http://siddhesh.in