This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PowerPC: use libgcc _Unwind functions to get backtrace


On Thu, Jul 25, 2013 at 8:53 AM, Adhemerval Zanella
<azanella@linux.vnet.ibm.com> wrote:
>> Ryan S. Arnold
>>
> Hi Ryan, thanks for the notes. You are correct and I realized it does needed to support
> the non vDSO test (Linux 2.6.19 already provides the signal trampolines for PPC32
> and PPC64). I also corrected the comments you pointed out.
>
> Following Joseph comments, I added another test (tst-backtrace6) and changed tst-backtrace5
> so the sa_flags can be changed if a define. The current behavior of tst-backtrace5 is unchanged.
> I also checked on x86_64 and x86 and tst-backtrace6 produces the same output as tst-backtrace5,
> it only changes for PPC32 that uses different signal trampolines depending of sa_flags.
>
> And since 2.18 is close, I'd like to push it to 2.19.
>
> What do you think now Ryan?

The patch looks good to me now and I'm fine with this going into 2.19.
 We can backport to 2.18 once the release branch is created.

Ryan S. Arnold


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]